987578 - [FTE] warning message about the number of tries left lost in "Enter PIN code" screen in FTU

Status: RESOLVED DUPLICATE of bug 974606

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Loli (:lolimartinezcr)]

Attachment: 2014-03-25-05-56-20.png

1.4
Gecko af8a9b7
Gaia a2a88d0
Git commit: a2a88d06
Platform version: 30.0a2

Reproducible 100%

STR:
1) Tap Next button in "Language" screen.
2) Insert invalid PIN and tap OK button --> User see warning with tries
3) Tap "Skip" in PIN screen --> User see "Language" screen
4) Tap "Next" button.

Actual result:
User see "Enter PIN code" with red field "Type your PIN code" (See attached image)

Expected result:
User see "Enter PIN code" without red field "Type your PIN code"

Comment 1

[Noemí Freire (:noemi)]

Hi,

After re-testing again, changing a bit the STR:
1) Tap Next button in "Language" screen
2) Insert invalid PIN and tap OK button --> User sees a warning with the number of tries left
3) Tap "Skip" in PIN screen
4) "Select Network" screen appears
5) Tap "Back" button

Actual result:
"Enter PIN code" screen is shown but without the number of tries left (See "2014-03-25-05-56-20.png" image attached )

Expected result:
"Enter PIN code" screen is shown including the number of tries left (see "2014-03-25-09-22-54.png" image attached)

Notice that it properly works on today's (3/25) v1.3 build (see "2014-03-25-09-22-54.png" image attached):
Device: Hamachi
BuildId: 20140325055830
Gecko: 72f48b2
Gaia: b789780
Platform version: 28.0

so adding regression keyword and nominating to v1.4?

Comment 2

[Matthew Vaughan]

TINDERBOX:
- Last Working -
Device: Buri v1.4 MOZ RIL
BuildID: 20140306133147
Gaia: 98cf46d6623b164845fe1fdc99a2a7bf64aa667d
Gecko: 8095b7dd8f58
Version: 30.0a1
Firmware Version: v1.2-device.cfg

- First Broken -
Device: Buri v1.4 MOZ RIL
BuildID: 20140306174956
Gaia: 04eb7996543f114133d1367f834a4d88b68c60ac
Gecko: b0e7f63c2138
Version: 30.0a1
Firmware Version: v1.2-device.cfg


**This looks to be a gaia issue**
last working gaia/first broken gecko = NO REPRO
Gaia: 98cf46d6623b164845fe1fdc99a2a7bf64aa667d
Gecko: b0e7f63c2138

first broken gaia/last working gecko = REPRO
Gaia: 04eb7996543f114133d1367f834a4d88b68c60ac
Gecko: 8095b7dd8f58

Push log: https://github.com/mozilla-b2g/gaia/compare/98cf46d6623b164845fe1fdc99a2a7bf64aa667d...04eb7996543f114133d1367f834a4d88b68c60ac


B2G INBOUND:
- Last Working -
Device: Buri ENG v1.4 MOZ RIL
BuildID: 20140306100206
Gaia: 9210e0cb90a3aaa0bd78a418fad0fde9330068d2
Gecko: 70b04b433345
Version: 30.0a1
Firmware Version: v1.2-device.cfg

- First Broken -
Device: Buri ENG v1.4 MOZ RIL
BuildID: 20140306102107
Gaia: 023dfae0ed312551fdc9031bd911722193ae9262
Gecko: dfa91c182bea
Version: 30.0a1
Firmware Version: v1.2-device.cfg

Push log: https://github.com/mozilla-b2g/gaia/compare/9210e0cb90a3aaa0bd78a418fad0fde9330068d2...023dfae0ed312551fdc9031bd911722193ae9262

Comment 3

[Michael Henretty [:mikehenrty][:mhenretty]]

This was caused by https://github.com/mozilla-b2g/gaia/commit/d394c63dd40355a80e578a6bde6d5ce7251526aa. However, the fact that it "worked" on 1.3 is due to bug 965774. Arguably, it's not actually working in 1.3 either but just that the retry message erroneously sticks around after skipping the SIM Pin screen, which causes problems in the dsds scenario.

My thinking here is that this bug has already been fixed in bug 966571. But unfortunately due to bug 974606 we have no ability to verify this when using MozRIL. To be more specific, MozRIL is missing an API call that will allow us to explicitly query and then display the retry count. Instead, we can only get that count after entering a wrong PIN. The end effect of this is that the SIM screens never shows retry count up front, but only after entering the wrong pin, as the STR here state. This should work fine with a RIL that supports querying the retry count.

Jason, my suggestion is to mark this bug as WORKSFORME, and then get QC to verify this similar to bug 966571 comment 31. What do you think?

Comment 4

[Jason Smith [:jsmith]]

We probably should dupe to bug 974606 actually, as that's the root reason why we're hitting this problem.