987641 - Uplift bug 984823 and its dependencies to aurora/b2g1.4

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Comment 1

[Nicolas Silva [:nical]]

Attachment: Rebase of the texture pool patch from bug 980647 (acrrying r+) for aurora

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: Bug 984823 (already approved for the uplift) depends on this patch.
Testing completed (on m-c, etc.): 2014-03-18
Risk to taking this patch (and alternatives if risky): low risk 
String or IDL/UUID changes made by this patch:

Comment 2

[Nicolas Silva [:nical]]

Attachment: Rebase of the patch from bug 984823 (carrying r+) for aurora

This patch already is marked 1.4+ in bug 984823

Comment 3

[Nicolas Silva [:nical]]

re-requesting 1.4? (already approved in bug 984823) to help tracking this.

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

This is already "resolved fixed" on central, and this bug just involves the uplift to aurora/1.4.  Not sure if the right thing is to tag is as resolved fixed, or checkin-needed.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/79303d2634e5
https://hg.mozilla.org/releases/mozilla-aurora/rev/55f248b19a5a

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Backed out for bustage.
https://hg.mozilla.org/releases/mozilla-aurora/rev/d837df7b2049

https://tbpl.mozilla.org/php/getParsedLog.php?id=36758401&tree=Mozilla-Aurora

Comment 7

[Milan Sreckovic [:milan] (needinfo for best results)]

The build error is an easy one, just a missing line in CompositorOGL.h.  However, I took a quick look at the rest, and I'll leave it for Nicolas to sort out.  I'm not clear why the resulting CompositorOGL.cpp, for example, would look different between aurora and the trunk, but with these patches, they would be different.  For example, PerFrameTexturePoolOGL::DestroyTextures with the patches above just calls EndFrame() twice, while the trunk implementation that appears very much different.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

FWIW, the bustage was debug-only.

Comment 9

[Nicolas Silva [:nical]]

Attachment: Rollup patch (carrying r+)

Comment 10

[Nicolas Silva [:nical]]

Fixed and relanded:
https://hg.mozilla.org/releases/mozilla-aurora/rev/626abcc6cbc4

 PerFrameTexturePoolOGL::DestroyTextures with the patches above just calls
> EndFrame() twice, while the trunk implementation that appears very much
> different.

That was me rebasing a version of the patch that missed the last review nits. I fixed this in attachment 8397802 [details] [diff] [review] that I just landed.