Closed Bug 987688 Opened 6 years ago Closed 5 years ago

LDAP c-sdk doesn't pass CFLAGS/LDFLAGS during linking of "now.o"

Categories

(Thunderbird :: Build Config, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: decoder, Unassigned)

References

(Blocks 1 open bug)

Details

When I try to build Thunderbird with AddressSanitizer, I hit an error while it tries to link "now.o" in <objdir>/ldap/sdks/c-sdk/config. Looking at the Makefile, it seems that stuff is built with our CFLAGS but not linked with our CFLAGS/LDFLAGS which breaks AddressSanitizer (but is also not a good idea in general).

Something like this fixes my build error, but is probably not the right fix:

>    diff --git a/c-sdk/config/Makefile.in b/c-sdk/config/Makefile.in
>    --- a/c-sdk/config/Makefile.in
>    +++ b/c-sdk/config/Makefile.in
>    @@ -135,9 +135,9 @@ endif
>     define MAKE_OBJDIR
>     if test ! -d $(@D); then rm -rf $(@D); mkdir $(@D); else true; fi
>     endef
>     
>     export:: $(TARGETS)
>     
>     $(OBJDIR)/%$(PROG_SUFFIX): $(OBJDIR)/%.$(OBJ_SUFFIX)
>            @$(MAKE_OBJDIR)
>    -       $(CC) $(XCFLAGS) $< $(XLDOPTS) $(OUTOPTION)$@
>    +       $(CC) $(CFLAGS) $(XCFLAGS) $< $(XLDOPTS) $(OUTOPTION)$@
Hey, LDAP C SDK is no longer built; it's all in moz.build now. YAY! NO MORE BLOODY F@#!$!@$ING LINK ERRORS.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.