987701 - Lots of tabview asserts: tabview assert: should already be linked

Status: RESOLVED WONTFIX

(Firefox Graveyard :: Panorama, defect)

Description

[:Gijs (he/him)]

0:10.09 TEST-INFO | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_968565_insert_before_hidden_items.js | Console message: tabview assert: should already be linked
 0:10.09 TabItems_update@chrome://browser/content/tabview.js:5661:7
 0:10.09 TabItems_init/this._eventListeners.attrModified@chrome://browser/content/tabview.js:5540:9
 0:10.09 _tabAttrModified@chrome://browser/content/tabbrowser.xml:1178:11
 0:10.09 setTabTitle@chrome://browser/content/tabbrowser.xml:1233:13
 0:10.09 swapNewTabWithBrowser@chrome://browser/content/tabbrowser.xml:2156:13
 0:10.09 HiddenBrowser.prototype.swapWithNewTab@resource:///modules/CustomizationTabPreloader.jsm:114:5
 0:10.09 this.CustomizationTabPreloaderInternal.newTab@resource:///modules/CustomizationTabPreloader.jsm:74:7
 0:10.09 this.CustomizationTabPreloader.newTab@resource:///modules/CustomizationTabPreloader.jsm:44:5
 0:10.09 addTab@chrome://browser/content/tabbrowser.xml:1587:15
 0:10.09 loadOneTab@chrome://browser/content/tabbrowser.xml:1283:1
 0:10.09 openLinkIn@chrome://browser/content/utilityOverlay.js:321:1
 0:10.09 openUILinkIn@chrome://browser/content/utilityOverlay.js:199:3
 0:10.09 switchToTabHavingURI@chrome://browser/content/browser.js:16472:7
 0:10.09 CustomizeMode.prototype.enter@resource:///modules/CustomizeMode.jsm:159:1
 0:10.09 startCustomizing@chrome://mochitests/content/browser/browser/components/customizableui/test/head.js:226:3
 0:10.09 @chrome://mochitests/content/browser/browser/components/customizableui/test/browser_968565_insert_before_hidden_items.js:73:3
 0:10.09 TaskImpl_run@resource://gre/modules/Task.jsm:298:1
 0:10.09 TaskImpl@resource://gre/modules/Task.jsm:247:3
 0:10.09 createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:224:7
 0:10.09 Task_spawn@resource://gre/modules/Task.jsm:139:5
 0:10.09 TaskImpl_handleResultValue@resource://gre/modules/Task.jsm:326:7
 0:10.09 TaskImpl_run@resource://gre/modules/Task.jsm:300:9
 0:10.09 resolve@resource://gre/modules/commonjs/sdk/core/promise.js:118:11
 0:10.09 then@resource://gre/modules/commonjs/sdk/core/promise.js:43:43
 0:10.09 resolve@resource://gre/modules/commonjs/sdk/core/promise.js:185:11
 0:10.09 TaskImpl_run@resource://gre/modules/Task.jsm:307:9
 0:10.09 TaskImpl_handleResultValue@resource://gre/modules/Task.jsm:338:7
 0:10.09 TaskImpl_run@resource://gre/modules/Task.jsm:300:9
 0:10.09 Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:707:11
 0:10.09 this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:586:7


that was from a local run, but see e.g. https://tbpl.mozilla.org/php/getParsedLog.php?id=36658286&tree=Fx-Team&full=1 .

Tim, do you know what this is? At first I thought that it's the fault of the tabview test from bug 967000, but it seems to predate that. :-(

Comment 1

[Justin Dolske [:Dolske]]

Panorama has been removed from Firefox 45, currently in Beta and scheduled for release on March 7th. As such, I'm closing all existing Panorama bugs.

If you are still using Panorama, you will see a deprecation message in Firefox 44, and when 45 is released your tab group data will be migrated to bookmarks, with a folder for each group. There are also a few addons offering similar functionality.

See https://support.mozilla.org/en-US/kb/tab-groups-removal for more info.

We're removing Panorama because it has extremely low usage (about 0.01% of users), and has a large number of bugs and usability issues. The cost of fixing all those issues is far too high to justify, and so we'll instead be focusing our time and energy on improving other parts of Firefox.