987783 - Main window not honoring background colors

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect)

Description

[Mike Kaply [:mkaply]]

In Australis, the main window no longer accepts a background color. It is always transparent.

I'm providing a testcase to show this, but this has a major impact on our theming project.

To see this, load any persona/background.

Enable chrome devtools.

Bring up the scratchpad and set the environment to browser.

Type:

document.getElementById("main-window").style.backgroundImage = "none";

The color of the main window should revert to the background color of the persona, not transparent.

Comment 1

[Mike Kaply [:mkaply]]

Regression range is:

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=298f262f21ff&tochange=61fd0f987cf2

Comment 2

[Markus Stange [:mstange]]

Wait, does that mean that background-image works on the window even when -moz-appearance is not none?

I think it shouldn't, and we should whatever bug that causes the window buttons to turn black if -moz-appearance is none.

Comment 3

[Mike Kaply [:mkaply]]

> Wait, does that mean that background-image works on the window even when -moz-appearance is not none?

Yes, that's how it has always worked on Windows. -moz-appearance is set to -moz-win-borderless-glass and personas/backgrounds apply just fine by setting background-color and background-image directly on the main-window.

This was before the patch from bug 889085

> I think it shouldn't, and we should whatever bug that causes the window buttons to turn black if -moz-appearance is none.

I have no opinion on that, I just know this is a pretty serious regression for our add-on and I'd like to get something done before Firefox 29 ships.

Comment 4

[Mike Kaply [:mkaply]]

I believe this display: none:

http://mxr.mozilla.org/mozilla-central/source/browser/themes/windows/browser-aero.css#102

is what is making them disappear.

If I remove the display: none via DOM inspector, the buttons function, but they still don't draw properly.

Comment 5

[Stefan [:stefanh]]

This is also a bit odd: In the windows version of global.css there's a '-moz-appearance: window;" rule, but it looks like NS_THEME_WINDOW isn't used in nsNativeThemeWin.cpp.

Comment 6

[Mike Kaply [:mkaply]]

I'd love to figure out how to fix this correctly right now, but I don't think we have time.

I know this breaks background/Personas for Firefox 29 and my wager is it is breaking themes as well.

My guess is it's the second patch from bug 889085 that is causing this. Should it be backed out or just made Mac only.

I'll put together whatever patch is needed.

Comment 7

[Markus Stange [:mstange]]

Backing it out from 29 seems safest. For 30+ we can put together a proper patch.

Comment 8

[Stefan [:stefanh]]

Backing out both patches makes most sense, since the first one depends on the second.

Comment 9

[:Gijs (he/him)]

It seems from bug 889085 that it was indeed backed out; can this be resolved WFM?