Closed Bug 987784 Opened 6 years ago Closed 6 years ago

Update the browser console default prefs to match those of the web console

Categories

(DevTools :: Console, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 31

People

(Reporter: msucan, Assigned: msucan)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch bug987784-1.diff (obsolete) — Splinter Review
Browser Console also needs to be less noisy.

Try push: https://tbpl.mozilla.org/?tree=Try&rev=0c1d410b6acc
Assignee: nobody → mihai.sucan
Status: NEW → ASSIGNED
Attachment #8396547 - Flags: review?(rcampbell)
Comment on attachment 8396547 [details] [diff] [review]
bug987784-1.diff

Review of attachment 8396547 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/app/profile/firefox.js
@@ +1228,5 @@
>  pref("devtools.webconsole.filter.cssparser", false);
>  pref("devtools.webconsole.filter.csslog", false);
>  pref("devtools.webconsole.filter.exception", true);
>  pref("devtools.webconsole.filter.jswarn", false);
> +pref("devtools.webconsole.filter.jslog", false);

why are we hiding jslog? What is it?

@@ +1246,4 @@
>  pref("devtools.browserconsole.filter.csslog", false);
>  pref("devtools.browserconsole.filter.exception", true);
> +pref("devtools.browserconsole.filter.jswarn", false);
> +pref("devtools.browserconsole.filter.jslog", false);

I'm not sure we want to turn these off. Browser Console is there for diagnostics. If we start hiding that browser developers are going to be confused.
Attachment #8396547 - Flags: review?(rcampbell)
(In reply to Rob Campbell [:rc] (:robcee) from comment #2)
> Comment on attachment 8396547 [details] [diff] [review]
> bug987784-1.diff
> 
> Review of attachment 8396547 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: browser/app/profile/firefox.js
> @@ +1228,5 @@
> >  pref("devtools.webconsole.filter.cssparser", false);
> >  pref("devtools.webconsole.filter.csslog", false);
> >  pref("devtools.webconsole.filter.exception", true);
> >  pref("devtools.webconsole.filter.jswarn", false);
> > +pref("devtools.webconsole.filter.jslog", false);
> 
> why are we hiding jslog? What is it?

In the webconsole we only get js warnings or exceptions from nsIScriptErrors. The JS drop-down only lists two severities: Errors and Warnings.

For the browserconsole we introduced JS log messages, thanks to the nsIConsoleMessages we display. They have no warning/error flags.

> @@ +1246,4 @@
> >  pref("devtools.browserconsole.filter.csslog", false);
> >  pref("devtools.browserconsole.filter.exception", true);
> > +pref("devtools.browserconsole.filter.jswarn", false);
> > +pref("devtools.browserconsole.filter.jslog", false);
> 
> I'm not sure we want to turn these off. Browser Console is there for
> diagnostics. If we start hiding that browser developers are going to be
> confused.

I see your point. Going to re-enable these two.
Attached patch bug987784-2.diffSplinter Review
Updated to allow jslog and jswarn messages by default.
Attachment #8396547 - Attachment is obsolete: true
Attachment #8397022 - Flags: review?(rcampbell)
Attachment #8397022 - Flags: review?(rcampbell) → review+
Thanks Rob!
Keywords: checkin-needed
Note, I had to strip the tryserver syntax from this patch.
https://hg.mozilla.org/mozilla-central/rev/0341229bbac4
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 31
Flags: in-testsuite+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.