987784 - Update the browser console default prefs to match those of the web console

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Comment 1

[Mihai Sucan [:msucan]]

Attachment: bug987784-1.diff

Browser Console also needs to be less noisy.

Try push: https://tbpl.mozilla.org/?tree=Try&rev=0c1d410b6acc

Comment 2

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 8396547 [details] [diff] [review]
bug987784-1.diff

Review of attachment 8396547 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/app/profile/firefox.js
@@ +1228,5 @@
>  pref("devtools.webconsole.filter.cssparser", false);
>  pref("devtools.webconsole.filter.csslog", false);
>  pref("devtools.webconsole.filter.exception", true);
>  pref("devtools.webconsole.filter.jswarn", false);
> +pref("devtools.webconsole.filter.jslog", false);

why are we hiding jslog? What is it?

@@ +1246,4 @@
>  pref("devtools.browserconsole.filter.csslog", false);
>  pref("devtools.browserconsole.filter.exception", true);
> +pref("devtools.browserconsole.filter.jswarn", false);
> +pref("devtools.browserconsole.filter.jslog", false);

I'm not sure we want to turn these off. Browser Console is there for diagnostics. If we start hiding that browser developers are going to be confused.

Comment 3

[Mihai Sucan [:msucan]]

(In reply to Rob Campbell [:rc] (:robcee) from comment #2)
> Comment on attachment 8396547 [details] [diff] [review]
> bug987784-1.diff
> 
> Review of attachment 8396547 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: browser/app/profile/firefox.js
> @@ +1228,5 @@
> >  pref("devtools.webconsole.filter.cssparser", false);
> >  pref("devtools.webconsole.filter.csslog", false);
> >  pref("devtools.webconsole.filter.exception", true);
> >  pref("devtools.webconsole.filter.jswarn", false);
> > +pref("devtools.webconsole.filter.jslog", false);
> 
> why are we hiding jslog? What is it?

In the webconsole we only get js warnings or exceptions from nsIScriptErrors. The JS drop-down only lists two severities: Errors and Warnings.

For the browserconsole we introduced JS log messages, thanks to the nsIConsoleMessages we display. They have no warning/error flags.

> @@ +1246,4 @@
> >  pref("devtools.browserconsole.filter.csslog", false);
> >  pref("devtools.browserconsole.filter.exception", true);
> > +pref("devtools.browserconsole.filter.jswarn", false);
> > +pref("devtools.browserconsole.filter.jslog", false);
> 
> I'm not sure we want to turn these off. Browser Console is there for
> diagnostics. If we start hiding that browser developers are going to be
> confused.

I see your point. Going to re-enable these two.

Comment 4

[Mihai Sucan [:msucan]]

Attachment: bug987784-2.diff

Updated to allow jslog and jswarn messages by default.

Comment 5

[Mihai Sucan [:msucan]]

Thanks Rob!

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/fx-team/rev/0341229bbac4

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Note, I had to strip the tryserver syntax from this patch.

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/0341229bbac4