Closed Bug 987825 Opened 7 years ago Closed 7 years ago
build tests are failing because we've added camera configuration options
As part of the camera refactoring, we've changed the camera build system to be independent of the build/ directory, and we've added new configuration options, so our generated config files are no longer the same as they were when the build was being handled by the build/ scripts. Build tests are failing now, and I think we should just disable those tests and remove any camera-specific build steps from the build/ directory if they are no longer needed.
This patch just removes the camera build tests that were failing. They were much too brittle, especially given that we will be changing our build time configuration system fairly dramatically.
Comment on attachment 8396538 [details] [review] link to github pull request Changing review request to Gareth. Yuren: I've set feedback? so you're aware of this change.
The patch has landed only on camera-new-features so that we can get a Travis build running to see if it fixes the problems we are having. It has not been uplifted to master yet. I agree, in principle, that there ought to be tests of the camera build system. We have pending work that will completely change our build-time configuration stuff, so working to update the brittle test now doesn't make sense. These build tests were introduced without any input from the media team and they have broken our workflow, and we really have to remove them today in order to get 1.4+ work done.
Comment on attachment 8396538 [details] [review] link to github pull request got it, thanks.
Attachment #8396538 - Flags: feedback?(yurenju.mozilla) → feedback+
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Bulk edit for camera bugs. If earlier comments do not show how this bug landed to master, it probably landed as part of https://github.com/mozilla-b2g/gaia/pull/17599 which merged the camera-new-features branch into master. This bug was uplifted from master to v1.4 as part of https://github.com/mozilla-b2g/gaia/commit/a8190d08e61316a86bba572ba8d894d081a20530
You need to log in before you can comment on or make changes to this bug.