987890 - Hide unhelpful tools from the add-on debugger

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Dave Townsend [:mossop]]

Some of the tools in the toolbox don't really work or work poorly for add-ons. We should probably hide those that are irrelevant.

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

https://tbpl.mozilla.org/?tree=Try&rev=40c3a1e04410

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 987890-disable-tools-in-addon-debugger.patch

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 987890-disable-tools-in-addon-debugger.patch

Forgot to change the comment describing the test.

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8398038 [details] [diff] [review]
987890-disable-tools-in-addon-debugger.patch

Review of attachment 8398038 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good overall!

::: browser/devtools/debugger/test/browser_dbg_addon-panels.js
@@ +1,4 @@
> +/* Any copyright is dedicated to the Public Domain.
> +   http://creativecommons.org/publicdomain/zero/1.0/ */
> +
> +// Ensure that the sources listed when debugging an addon are either from the 

Nit: trailing space

@@ +50,5 @@
> +function testPanels(frame) {
> +  let tabs = frame.contentDocument.getElementById("toolbox-tabs").children;
> +  let expectedTabs = ["options", "jsdebugger"];
> +
> +  is(tabs.length, 2, "displaying only 4 tabs in addon debugger");

4 -> 2

@@ +73,5 @@
> +  gAddon = null;
> +  gThreadClient = null;
> +  gDebugger = null;
> +  gSources = null;
> +  while (gBrowser.tabs.length > 1)

Local style uses braces even for one-line blocks.

::: browser/devtools/framework/target.js
@@ +190,5 @@
>      this._form = tab.form;
>      this._client = tab.client;
>      this._chrome = tab.chrome;
> +
> +    if (this._form && this._form.addonActor)

Probably fine to just put this expression in the getter, rather than saving separate state here.

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8398042 [details] [diff] [review]
987890-disable-tools-in-addon-debugger.patch

See comments on v1. :)

Comment 6

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 987890-disable-tools-in-addon-debugger.patch

Updated with nits fixed, awaiting try results: https://tbpl.mozilla.org/?tree=Try&rev=afbeaad6a641

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/f8f0f7a84d14

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f8f0f7a84d14