Open Bug 987897 Opened 11 years ago Updated 3 years ago

Infallibilize xpc::TransplantObject

Categories

(Core :: XPConnect, defect)

24 Branch
defect

Tracking

()

People

(Reporter: mccr8, Unassigned)

Details

(Keywords: sec-want)

xpc::TransplantObject is called in three places. All but one just crash if it fails. The third one is in nsGlobalWindow::SetNewDocument which is large and scary, so we should probably just crash there, too. In turn, JS_TransplantObject is only called by TransplantObject, so we should be able to make that infallible, too. Does that sounds reasonable, Bobby? (I'm just filing this as sec-want because it shouldn't be a common problem.)
Yeah, sounds good.
Assignee: nobody → continuation
Group: core-security → dom-core-security
Assignee: continuation → nobody
Group: dom-core-security

It looks like JS_TransplantObject was already infallible as of bug 793904, but xpc::TransplantObject can still fail for other reasons.

Summary: Infallibilize xpc::TransplantObject and JS_TransplantObject → Infallibilize xpc::TransplantObject
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.