987942 - Check for PK11_CreateContextBySymKey returning null

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect)

Comment 1

[Eric Rescorla (:ekr)]

See:
http://hg.mozilla.org/mozilla-central/annotate/fa098f9fe89c/media/mtransport/nricectx.cpp#l135

Marked security until we verify that this is just a null pointer dereference.

Comment 2

[Eric Rescorla (:ekr)]

See:
http://hg.mozilla.org/mozilla-central/annotate/fa098f9fe89c/media/mtransport/nricectx.cpp#l135

Marked security until we verify that this is just a null pointer dereference.

Comment 3

[Byron Campen [:bwc]]

This is just a null pointer deref in PK11_DigestBegin.

Comment 4

[Byron Campen [:bwc]]

Attachment: Check whether PK11_CreateContextBySymKey returns null

Comment 5

[Byron Campen [:bwc]]

Comment on attachment 8400229 [details] [diff] [review]
Check whether PK11_CreateContextBySymKey returns null

Review of attachment 8400229 [details] [diff] [review]:
-----------------------------------------------------------------

Also, we can unmark this as security, since this is just a null pointer member access.

Comment 6

[Eric Rescorla (:ekr)]

Comment on attachment 8400229 [details] [diff] [review]
Check whether PK11_CreateContextBySymKey returns null

Review of attachment 8400229 [details] [diff] [review]:
-----------------------------------------------------------------

Please revert this formatting change.

::: media/mtransport/nricectx.cpp
@@ +131,5 @@
>    if (!skey)
>      goto abort;
>  
>  
> +  hmac_ctx = PK11_CreateContextBySymKey(mech, CKA_SIGN, skey, &param);

Superfluous reformatting.

Comment 7

[Byron Campen [:bwc]]

Attachment: Check whether PK11_CreateContextBySymKey returns null

Undo formatting change.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9814945feba2

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9814945feba2