Closed Bug 987976 Opened 11 years ago Closed 11 years ago

MediaStreamAudioSourceNode/MediaElementAudioSourceNode output channel count should not depend on channelCountMode

Categories

(Core :: Web Audio, defect, P3)

x86_64
Linux
defect

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: karlt, Assigned: karlt)

References

Details

Attachments

(2 files)

"The number of channels of the output corresponds to the number of channels of the AudioMediaStreamTrack. If there is no valid audio track, then the number of channels output will be one silent channel." AudioNodeExternalInputStream should not be using AudioNodeStream::ComputeFinalOuputChannelCount() because that is intended for input up/down mixing. MediaStreamAudioSourceNode has no inputs. channelCountMode defaults to max and so will have no effect unless set. See also https://github.com/WebAudio/web-audio-api/issues/286#issuecomment-33511528
The difference from Blink here is that Blink plays silence for if element channel counts are > 32, but here more channels are down-mixed. Media stream channel counts are also fixed to 2 in Blink, but that restriction is not applied here. Leaving the "inline" const static/class member initialization of MaxChannelCount left missing symbols with gcc 4.7.3.
Assignee: nobody → karlt
Status: NEW → ASSIGNED
Attachment #8399266 - Flags: review?(paul)
to remove any implication that the function might be for calculating the number of output channels for an AudioNode.
Attachment #8399268 - Flags: review?(paul)
Attachment #8399266 - Flags: review?(paul) → review+
Attachment #8399268 - Flags: review?(paul) → review+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: