Closed Bug 987984 Opened 8 years ago Closed 8 years ago

VirtualenvManager.call_setup() uses the system python executable even after calling activate_this.py

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla31

People

(Reporter: ahal, Assigned: ahal)

References

Details

Attachments

(1 file)

This means we can't install a package using setup.py into the activated virtualenv.
Correct me if I'm wrong, but I believe we always want to use self.python_path, even if the virtualenv is not activated.. right?
Attachment #8396712 - Flags: review?(gps)
Comment on attachment 8396712 [details] [diff] [review]
Use self.python_path instead of sys.executable

Review of attachment 8396712 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. What could possibly go wrong?
Attachment #8396712 - Flags: review?(gps) → review+
Great, now you've all but guaranteed that I'm going to break something..
https://hg.mozilla.org/integration/mozilla-inbound/rev/74f3ae65bdf6
https://hg.mozilla.org/mozilla-central/rev/74f3ae65bdf6
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Maybe activate_this.py should change sys.executable?
See – https://groups.google.com/d/topic/python-virtualenv/hJqC_i58rqU/discussion
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.