987984 - VirtualenvManager.call_setup() uses the system python executable even after calling activate_this.py

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Andrew Halberstadt [:ahal]]

This means we can't install a package using setup.py into the activated virtualenv.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Use self.python_path instead of sys.executable

Correct me if I'm wrong, but I believe we always want to use self.python_path, even if the virtualenv is not activated.. right?

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8396712 [details] [diff] [review]
Use self.python_path instead of sys.executable

Review of attachment 8396712 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. What could possibly go wrong?

Comment 3

[Andrew Halberstadt [:ahal]]

Great, now you've all but guaranteed that I'm going to break something..
https://hg.mozilla.org/integration/mozilla-inbound/rev/74f3ae65bdf6

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/74f3ae65bdf6

Comment 5

[Piotr Dobrogost]

Maybe activate_this.py should change sys.executable?
See – https://groups.google.com/d/topic/python-virtualenv/hJqC_i58rqU/discussion