Closed Bug 987993 Opened 10 years ago Closed 10 years ago

Restore ThebesLayerComposite's Name() to be "ThebesLayerComposite"

Categories

(Core :: Graphics: Layers, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: botond, Assigned: botond)

References

Details

Attachments

(1 file)

In bug 968833, we changed the type of ThebesLayerComposite from TYPE_SHADOW to TYPE_THEBES by removing the declaration 'MOZ_LAYER_DECL_NAME("ThebesLayerComposite", TYPE_SHADOW)'. 

That macro expanded to a declaration of both GetType() and Name(); by removing it, we changed the Name() of a ThebesLayerComposite from "ThebesLayerComposite" to the name reported by the base class, "ThebesLayer".

This affects my ability to grep for "LayerComposite" in "adb logcat" to see compositor-side layer dumps (and is just inconsistent in general, as all other shadow layers have names ending in "Composite"), so I'd like to change the name back.
Attached patch bug987993.patchSplinter Review
Assignee: nobody → botond
Attachment #8396700 - Flags: review?(bjacob)
Attachment #8396700 - Flags: review?(bjacob) → review+
https://hg.mozilla.org/mozilla-central/rev/8e3a8c0eb620
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: