Closed
Bug 987993
Opened 11 years ago
Closed 11 years ago
Restore ThebesLayerComposite's Name() to be "ThebesLayerComposite"
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: botond, Assigned: botond)
References
Details
Attachments
(1 file)
|
994 bytes,
patch
|
bjacob
:
review+
|
Details | Diff | Splinter Review |
In bug 968833, we changed the type of ThebesLayerComposite from TYPE_SHADOW to TYPE_THEBES by removing the declaration 'MOZ_LAYER_DECL_NAME("ThebesLayerComposite", TYPE_SHADOW)'.
That macro expanded to a declaration of both GetType() and Name(); by removing it, we changed the Name() of a ThebesLayerComposite from "ThebesLayerComposite" to the name reported by the base class, "ThebesLayer".
This affects my ability to grep for "LayerComposite" in "adb logcat" to see compositor-side layer dumps (and is just inconsistent in general, as all other shadow layers have names ending in "Composite"), so I'd like to change the name back.
|
Assignee | |
Comment 1•11 years ago
|
||
Assignee: nobody → botond
Attachment #8396700 -
Flags: review?(bjacob)
|
||
Updated•11 years ago
|
Attachment #8396700 -
Flags: review?(bjacob) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
| landing | ||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•