Closed
Bug 988025
Opened 10 years ago
Closed 10 years ago
Restore JS_{CALLEE,ARGV,RVAL,SET_RVAL}
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: evilpie, Unassigned)
References
Details
Attachments
(1 file)
|
1023 bytes,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
Basically backout the last patch in Bug 845478. Jeff and I decided to not remove this during Firefox 31 so that the next SpiderMonkey release still has it.
|
Reporter | |
Comment 1•10 years ago
|
||
Attachment #8396735 -
Flags: review?(jwalden+bmo)
|
||
Comment 2•10 years ago
|
||
How much maintenance burden is carrying it around for the next year going to create?
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8396735 [details] [diff] [review] restore-functions No maintenance burden. Nobody on trunk is going to use these because we're going to remove 'em soon. Trunk approaches will backport trivially til we put CallArgs into JSNative's signature. And that change happening doesn't affect the ease of backports wrt these macros in any way.
Attachment #8396735 -
Flags: review?(jwalden+bmo) → review+
|
|
Reporter | |
Comment 4•10 years ago
|
||
Seems like we didn't need this..
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•