988037 - [B2G][Video] WebM videos attached in email do not display properly when previewed in email app

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Video, defect)

Description

[Brogan Zumwalt [Inactive]]

Attachment: Screenshot

Description:
When user previews WebM video attached in email the video is anchored to the top left of the screen and is not scaled properly, with part of the video being cut off in some cases. This issue does not happen when viewing same file in browser app or video app.

URL's of videos tested:
http://video.webmfiles.org/big-buck-bunny_trailer.webm
http://webm.html5.org/test.webm

Repro Steps:
1) Updated Open C to Build ID: 20140325040052
2) Set up Email app with valid account
3) Send WebM video as attatchment to email address set up in step 2
4) Open Email app on device and select recieved message with video attached
5) Click to download attachment then press "View"

Actual:
Video is not scaled correctly and may be cut off if large enough.

Expected:
Video displays properly with user able to see entire video.

Environmental Variables
Device: Open C v 1.3 Mozilla RIL
Build ID: 20140325040052
Gecko: 1e2ca6e4ab9a929fe3763057478ee516d67da7ad
Gaia: f1c58f9f3b5d538afdd71ad3c22106200bc7ece5
Platform Version: 28.0
Firmware Version: P821A10-ENG_20140321

Notes:
Repro frequency: 3/3, 100%
See attached: screenshot

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

The e-mail app never displays attachments itself, it always uses web activities.  This seems like there must be a bug in the Video app's "open" activity.  Moving to the video component.

Comment 2

[Brogan Zumwalt [Inactive]]

Additional testing shows this issue DOES occur on Buri, so this issue is not device specific.


Environmental Variables:
Device: Buri v mozRIL
BuildID: 20140325004002
Gaia: b789780c53adaac199787f51615375f721edfef4
Gecko: 37917eb0dfeb
Version: 28.0
Firmware Version: v1.2-device.cfg

Comment 3

[Jason Smith [:jsmith]]

Are we able to reproduce this by just playing the webm video directly from the video app, where the video is stored on your sdcard?

Comment 4

[Brogan Zumwalt [Inactive]]

This issue does not happen when viewing same file in browser app or video app.

Comment 5

[Jason Smith [:jsmith]]

This seems pretty bad. This means that you won't be able to view a good amount of the video from an email attachment.

Comment 6

[Hema Koka [:hema]]

Is this a regression? Don't remember any changes going into video app's open activity...

Comment 7

[Jason Smith [:jsmith]]

(In reply to Hema Koka [:hema] from comment #6)
> Is this a regression? Don't remember any changes going into video app's open
> activity...

The attachment feature is new, but the viewing of webm video via web activity was present on 1.1. We could write a reduced test case to see if this happens on 1.1 using web activities. However, this bug serves a higher importance in 1.3 than 1.1, since 1.1 didn't have email attachment support, where as 1.3 does, which means this bug is far more likely for a user to hit.

Comment 8

[Preeti Raghunath(:Preeti)]

Hema

Please help with assignee here.

Comment 9

[Hema Koka [:hema]]

Russ, Could you take a look and see whats going on (1.3 build)?

Comment 10

[John Hu [:johnhu][:johu][:醬糊小弟]]

We had fixed almost all issues about player size with the supported format: ogv, webm, 3gp, and mp4, before.

The codes related to player size are at:
https://github.com/mozilla-b2g/gaia/blob/v1.3/apps/video/js/video_utils.js
https://github.com/mozilla-b2g/gaia/blob/v1.3/apps/video/js/view.js#L230

Comment 11

[John Hu [:johnhu][:johu][:醬糊小弟]]

Ok, I remember that. In master, I had fixed a videoRotation error when writing patch for tablet. I think that may be related to this bug.

https://github.com/mozilla-b2g/gaia/blob/master/apps/video/js/view.js#L58-L64
https://github.com/mozilla-b2g/gaia/blob/v1.3/apps/video/js/view.js#L58-L62

Comment 12

[Russ Nicoletti [:russn]]

John, you're right. The change in comment #11 fixes the issue. PR comming.

Comment 13

[Russ Nicoletti [:russn]]

Attachment: Pull request: https://github.com/mozilla-b2g/gaia/pull/17931

Comment 14

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8401014 [details] [review]
Pull request: https://github.com/mozilla-b2g/gaia/pull/17931

Thanks for this patch. It looks nice.

Comment 15

[Russ Nicoletti [:russn]]

v1.3:

https://github.com/mozilla-b2g/gaia/commit/780298ef470eb4379646c4986d86042844023a4d

Comment 16

[Ryan VanderMeulen [:RyanVM]]

When did this get approval to land on v1.3? Per the tree rules that have been in place for nearly 2 months now, *all* v1.3 require explicit approval regardless of blocking status.
https://wiki.mozilla.org/Release_Management/B2G_Landing

Also, you need to set the proper status flags when landing on release branches. And does this need to land on v1.4?

Comment 17

[Russ Nicoletti [:russn]]

Apologies, my mistake for not getting approval. Will request approval now. Btw, this issue doesn't exist in 1.4 and master.

Comment 18

[Russ Nicoletti [:russn]]

Attachment: Request for 1.3 uplift

Requesting approval for v1.3 uplift of this PR (the issue does not exist in 1.4 or master).

[User impact] User sees only part of a video when previewing it as an email attachment. Poor user experience, reflects badly on Mozilla quality.

[Testing completed]: Tested it before and after the fix on a buri device. Was able to reproduce the incorrect behavior prior to fix and verified the correct behavior with the fix.
 
[Risk to taking this patch] (and alternatives if risky): Small, six-line code change. These lines of code already exist in master.

Comment 19

[bhavana bajaj [:bajaj]]

(In reply to Brogan Zumwalt from comment #0)
> Created attachment 8396745 [details]
> Screenshot
> 
> Description:
> When user previews WebM video attached in email the video is anchored to the
> top left of the screen and is not scaled properly, with part of the video
> being cut off in some cases. This issue does not happen when viewing same
> file in browser app or video app.
> 
> URL's of videos tested:
> http://video.webmfiles.org/big-buck-bunny_trailer.webm
> http://webm.html5.org/test.webm
> 
> Repro Steps:
> 1) Updated Open C to Build ID: 20140325040052
> 2) Set up Email app with valid account
> 3) Send WebM video as attatchment to email address set up in step 2
> 4) Open Email app on device and select recieved message with video attached
> 5) Click to download attachment then press "View"
> 
> Actual:
> Video is not scaled correctly and may be cut off if large enough.
> 
> Expected:
> Video displays properly with user able to see entire video.
> 
> Environmental Variables
> Device: Open C v 1.3 Mozilla RIL
> Build ID: 20140325040052
> Gecko: 1e2ca6e4ab9a929fe3763057478ee516d67da7ad
> Gaia: f1c58f9f3b5d538afdd71ad3c22106200bc7ece5
> Platform Version: 28.0
> Firmware Version: P821A10-ENG_20140321
> 
> Notes:
> Repro frequency: 3/3, 100%
> See attached: screenshot

Brogan, can you please help verify this on the 1.3 build ?

Comment 20

[bhavana bajaj [:bajaj]]

Comment on attachment 8401461 [details] [review]
Request for 1.3 uplift

Just rubber-stamping this at this point. This has already a landed. Request to adhere to landing policies next time around.

I've also requested QA help to get this verified.

Comment 21

[Brogan Zumwalt [Inactive]]

Issue does NOT occur for Open C or Buri on latest 1.3
Environmental Variables:

Device: Buri v1.3 Mozilla RIL
BuildID: 20140404004002
Gaia: f06667bcaef2032849ddee736fffdd7d8d8c02f8
Gecko: 021a6f9c27f8
Version: 28.0

Device: Open C v1.3
BuildID: 20140404040052
Gaia: f06667bcaef2032849ddee736fffdd7d8d8c02f8
Gecko:815206f6549479cb7f788ce8065b07cc5b23aa69
Version: 28.0