Closed
Bug 988126
Opened 10 years ago
Closed 10 years ago
WebViewActivity.java:56 Possible null pointer dereference of uri in org.mozilla.gecko.sync.setup.activities.WebViewActivity.onCreate(Bundle)
Categories
(Firefox for Android Graveyard :: Android Sync, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 31
People
(Reporter: rnewman, Unassigned)
Details
(Whiteboard: findbugs)
Attachments
(1 file)
|
1.25 KB,
patch
|
rnewman
:
review+
|
Details | Diff | Splinter Review |
// Extract URI to launch from Intent.
Uri uri = this.getIntent().getData();
if (uri == null) {
Logger.debug(LOG_TAG, "No URI passed to display.");
finish();
}
...
wv.loadUrl(uri.toString());
We should return after that finish().
|
Reporter | |
Updated•10 years ago
|
Component: General → Android Sync
Product: Firefox for Android → Android Background Services
Version: Trunk → unspecified
|
||
Comment 1•10 years ago
|
||
Attachment #8398316 -
Flags: review?(rnewman)
|
|
||
Updated•10 years ago
|
Assignee: nobody → mozbugs.retornam
|
|
Reporter | |
Comment 2•10 years ago
|
||
Comment on attachment 8398316 [details] [diff] [review] bug-988126.patch This looks good, but it either needs to arrive as a pull request against https://github.com/mozilla-services/android-sync , or one of the ABS peers needs to make that happen. So don't land it yet!
Attachment #8398316 -
Flags: review?(rnewman) → review+
|
|
Reporter | |
Updated•10 years ago
|
Flags: needinfo?(rnewman)
Whiteboard: findbugs → findbugs [needs upstreaming]
|
|
Reporter | |
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/c49dd9f20936
Status: NEW → ASSIGNED
Flags: needinfo?(rnewman)
Whiteboard: findbugs [needs upstreaming] → findbugs
Target Milestone: --- → Firefox 31
https://hg.mozilla.org/mozilla-central/rev/c49dd9f20936
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
|
||
Updated•10 years ago
|
Assignee: mozbugs.retornam → nobody
|
||
Updated•7 years ago
|
Product: Android Background Services → Firefox for Android
|
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•