988139 - [b2g][tarako] In phone call, can't switch back to bt sco after switch to speaker

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Wayne Chen [:xwaynec]]

1. Connect a bt device
2. make a MT call
3. pick up the phone and BT is ok
4. switch to speaker and then switch back
5. BT device doesn't work

Comment 1

[Wayne Chen [:xwaynec]]

Hi Arthur,

As we talk, please help to fix in 1.3t.
Thanks


Sincerely,
Wayne

Comment 2

[James Zhang (Spreadtrum)]

Please cherry-pick 1.3 patch to v1.3t.

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: link to https://github.com/mozilla-b2g/gaia/pull/17626

Etienne, this is a v1.3t only bug. Could you help review the patch? Thanks.

Comment 4

[Joe Cheng [:jcheng] (please needinfo)]

Triage: seem like a regression for tarako only
ni? Rik as Etienne's on PTO

Comment 5

[Anthony Ricaud (:rik)]

Comment on attachment 8396925 [details]
link to https://github.com/mozilla-b2g/gaia/pull/17626

Before r+ing this, I'd like to know why we got this regression. This looks like a bad uplift and that might cause other regressions.

Comment 6

[Anthony Ricaud (:rik)]

So this https://github.com/mozilla-b2g/gaia/commit/a65b202e0f6d24668046f936108d8b650a02d353, the uplift of bug 980984.

Comment 7

[Anthony Ricaud (:rik)]

Comment on attachment 8396925 [details]
link to https://github.com/mozilla-b2g/gaia/pull/17626

The fix looks good but we need a test to make sure we don't regress again. I can see other uplifts to 1.3t that would get rid of that line again because master doesn't have it anymore.

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8396925 [details]
link to https://github.com/mozilla-b2g/gaia/pull/17626

As "settings" is not exposed, I turned to add tests for turnSpeakerOn and turnSpeakerOff.

Comment 9

[Anthony Ricaud (:rik)]

Comment on attachment 8396925 [details]
link to https://github.com/mozilla-b2g/gaia/pull/17626

r=me if you remove the changes in apps/system/js/window_manager.js

Thanks!

Comment 10

[Joe Cheng [:jcheng] (please needinfo)]

ni? Ying for uplift to 1.3T

Comment 11

[ying.xu]

I see some jslint errors.
Is that Ok to proceed?

Comment 12

[Anthony Ricaud (:rik)]

I don't see linter errors on https://travis-ci.org/mozilla-b2g/gaia/builds/21652779. Just keyboard errors so unrelated to dialer. I think it's ok to proceed.

Comment 13

[ying.xu]

https://github.com/mozilla-b2g/gaia/commit/1005258a01882d2e9a264403ab9e4a3d2b3230cc

Comment 14

[Joe Cheng [:jcheng] (please needinfo)]

Arthur, seem like you are actively working on this so i will mark the target milestone to 1.4 S5. please change it if you think otherwise. Thanks

Comment 15

[Rachel Pribble [:rpribble]]

Verified fixed on the Tarako v1.3T MOZ ril.

Environmental Variables:
Device: Tarako 1.3T
BuildID: 20140602014001
Gaia: 335486c42498fa7a93c21e4d6121199728602ab8
Gecko: 55e4d83019e5
Version: 28.1
Firmware Version: SP6821a-Gonk-4.0-4-29

Bluetooth device functions as expected.