Closed Bug 988174 Opened 10 years ago Closed 10 years ago

Extract UI to edit bookmarks

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
1.4 S5 (11apr)

People

(Reporter: crdlc, Assigned: crdlc)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

      No description provided.
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Blocks: 898325
Depends on: 988172
Whiteboard: [systemsfe]
Attached file Patch v1
Thanks a lot Dale!
Attachment #8402613 - Flags: review?(dale)
Hi Dale,

    Excuse me to interrupt you with these reviews but I would like to land the whole bookmarks migration during this week. This bug is ready to review when you have time, and also after landing this one, I have ready the bug 988177 regarding to remove bookmarks as well (this will be the last review, I hope so).

    I will be on holidays next week and I would like to land all those patches before my holidays. Because the sooner the better and also for me is better to land it asap in order to avoid conflicts during my PTO :)

    I appreciate a lot your help and friendliness

Thanks in advance,
Cristian
Flags: needinfo?(dale)
Hey christian, yup definitely, I will get to this tonight, cheers
Flags: needinfo?(dale)
OK, thanks Dale, I have added more unit and integration tests
Comment on attachment 8402613 [details]
Patch v1

Hah so my first comment was going to be integration tests

2 things I noticed, the 'Done' button on the your version is in italic, it isnt on master, and master blocks you from entering an empty string as a title, that is possible on your version.

Both are relatively minor nits, the rest of it looks great, so I would suggest fixing those before landing, but r+
Attachment #8402613 - Flags: review?(dale) → review+
Dale, you are right about italics. This is something I need to fix in headers BB. It should always be italics with the new VD.
Hi,

   1) According to Arnau and comment 6, the "Done" button style is ok

   2) Regarding to empty field you are right, good catch!

   3) I have to provide this feature: "User should have the option to clear the field" what I forgot when I did it one month ago (see https://bug938287.bugzilla.mozilla.org/attachment.cgi?id=832410)

Working on it in order to have the last bug (delete bookmarks) ready to review today :) Thanks a lot Dale
Merged in master:

https://github.com/mozilla-b2g/gaia/commit/4bc61f9faa7fe76c911b4a7f3f89424cd38400bf
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S5 (11apr)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: