988270 - The unit test of AppWindowManager will break other tests in system app (e.g. bootstrap)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Luke Chang [:lchang] (inactive)]

You will see following error message under unit testing process if you run "bootstrap_test.js" and "app_window_manager_test.js" at the same time.

--------------------------------------------

[system] "before each" hook

Error: TypeError: this._activeApp is undefined (http://system.gaiamobile.org:8080/js/app_window_manager.js?time=1395834285802:573)
    at onerror (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4959:7)
    at (anonymous) (http://system.gaiamobile.org:8080/test/unit/bootstrap_test.js:136:9)
    at wrapper (http://system.gaiamobile.org:8080/common/test/mocha_generators.js:62:13)
    at run (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709:7)
    at next (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3973:5)
    at (anonymous) (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3984:5)
    at (anonymous) (http://system.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4932:28)

Comment 1

[Luke Chang [:lchang] (inactive)]

That's because we don't call "removeEventListener" in AppWindowManager after test is finished.

Comment 2

[Luke Chang [:lchang] (inactive)]

Attachment: Pull Request 17680

Alive, could you please help to review it? Thanks!

Comment 3

[Luke Chang [:lchang] (inactive)]

travis passed:
https://travis-ci.org/mozilla-b2g/gaia/builds/21645175

merged in gaia master:
https://github.com/mozilla-b2g/gaia/commit/77fd538d3df846c0888cf971af3ae10df8558452


Alive, Thanks!