Closed
Bug 988306
Opened 10 years ago
Closed 10 years ago
DNS and DHCP records in inventory database are incompatible with mozpool
Categories
(Testing Graveyard :: Mozpool, defect)
Testing Graveyard
Mozpool
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: pmoore, Assigned: dustin)
References
Details
Attachments
(2 files, 1 obsolete file)
7.21 KB,
patch
|
dividehex
:
review+
juber
:
feedback+
|
Details | Diff | Splinter Review |
2.13 KB,
patch
|
dividehex
:
review+
|
Details | Diff | Splinter Review |
Due to this, crond is currently disabled on mobile-imaging-001, and the inventory sync script hacked to read MAC addresses from /tmp/nics.txt. The disabled cron will prevent puppet from running, too. We need to get Mozpool working with the new format of DNS and DHCP records in inventory database, so this workaround can be removed. This will mean mobile-imaging-001 will be under puppet control again, and we will pick up new device changes. Currently we are working from a static temporary list until this issue is resolved. Please see bug 988281 for the tree closure on 26 Mar 2014 that this relates to.
Assignee | ||
Updated•10 years ago
|
Assignee: relops → dustin
Component: RelOps → Mozpool
Product: Infrastructure & Operations → Testing
QA Contact: arich
Version: other → unspecified
Assignee | ||
Comment 1•10 years ago
|
||
I need some info on the inventory API to static registrations to do this /cc uberj
Reporter | ||
Comment 2•10 years ago
|
||
Component: RelOps → Mozpool; Version: other → unspecified; Assignee: relops@infra-ops.bugs → dustin@mozilla.com; Product: Infrastructure & Operations → Testing; QA Contact: arich@mozilla.com → i see i totally messed up with filing that one then! ;)
Assignee | ||
Comment 3•10 years ago
|
||
I'm a little bummed there's no pagination with the bulk export, but it seems to give results all the same.
Attachment #8397125 -
Flags: review?(jwatkins)
Attachment #8397125 -
Flags: feedback?(juber)
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8397125 [details] [diff] [review] bug988306.patch er, some tab conversion errors bringing that back from the production host..
Attachment #8397125 -
Attachment is obsolete: true
Attachment #8397125 -
Flags: review?(jwatkins)
Attachment #8397125 -
Flags: feedback?(juber)
Assignee | ||
Comment 5•10 years ago
|
||
This also ignores decommissioned hosts
Attachment #8397144 -
Flags: review?(jwatkins)
Attachment #8397144 -
Flags: feedback?(juber)
Assignee | ||
Comment 6•10 years ago
|
||
I'll ship the updated mozpool (with bug 988321 as well) as 4.2.0.
Attachment #8397188 -
Flags: review?(jwatkins)
Updated•10 years ago
|
Attachment #8397144 -
Flags: review?(jwatkins) → review+
Updated•10 years ago
|
Attachment #8397188 -
Flags: review?(jwatkins) → review+
Comment 7•10 years ago
|
||
Comment on attachment 8397144 [details] [diff] [review] bug988306-p1.patch Review of attachment 8397144 [details] [diff] [review]: ----------------------------------------------------------------- lgtm ::: mozpool/lifeguard/inventorysync.py @@ +83,3 @@ > > + try: > + mac_address = o['staticreg_set']['nic0']['hwadapter_set']['hw0']['mac'] Users are able to change the names of both SREG/HWAdapter objects in the UI, so if you are always sure that 'nic0' and 'hw0' will be along the lookup path, this will work. Maybe a more suggestive error message will help when someone fudges a name and can't figure out why a mac isn't showing up.
Attachment #8397144 -
Flags: feedback?(juber) → feedback+
Assignee | ||
Comment 8•10 years ago
|
||
Good point - I'll adjust the error message when landing. Thanks!
Assignee | ||
Comment 9•10 years ago
|
||
Will be in 4.2.0
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 10•10 years ago
|
||
Comment on attachment 8397144 [details] [diff] [review] bug988306-p1.patch Review of attachment 8397144 [details] [diff] [review]: ----------------------------------------------------------------- ::: mozpool/lifeguard/inventorysync.py @@ +83,5 @@ > > + try: > + mac_address = o['staticreg_set']['nic0']['hwadapter_set']['hw0']['mac'] > + except KeyError: > + if verbose: print hostname, 'SKIPPED - no MAC address' This is missing a 'continue'. I'll add that, but not release a new version of mozpool
Updated•8 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•