988408 - toolbox.js - focusTool() - TypeError: this.doc is undefined

Status: RESOLVED FIXED

(DevTools :: Framework, defect)

Description

[Mihai Sucan [:msucan]]

While running webconsole tests I see the following exception:

 1:58.75 TEST-PASS | chrome://mochitests/content/browser/browser/devtools/webconsole/test/browser_webconsole_js_input_expansion.js | height shrank to original size within 1px
 1:58.75 *************************
 1:58.75 A coding exception was thrown in a Promise resolution callback.
 1:58.75
 1:58.75 Full message: TypeError: this.doc is undefined
 1:58.75 See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise
 1:58.75 Full stack: Toolbox.prototype.focusTool@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/toolbox.js:872:1
 1:58.75 Toolbox.prototype.selectTool/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/toolbox.js:858:7
 1:58.75 Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:707:11
 1:58.75 this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:586:7
 1:58.75
 1:58.75 *************************

This is happening in several tests, not just the one mentioned here.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Fix a couple of races around toolbox opening and tool selection by waiting for the actual tool panel to be selected

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Hunh, bzexport seems to eat my comments lately, so here it goes:

This fixes 13 test failures in devtools with the patch from bug 1016387 applied. The first problem (that affected many tests) was that when opening the toolbox we were not waiting for the tool panel to be selected before firing toolbox-ready. The second was that we weren't using the selectTool() promise in one case to serialize execution. I got to remove a bunch of test code that waited on tool-selected after opening the toolbox as a result.

Try: https://tbpl.mozilla.org/?tree=Try&rev=de22d140c0f3

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/afb676164612

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/afb676164612