98844 - The DISABLE_LDAP build flag is broken in xpfe/bootstrap

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P3)

Description

[rpotts (gone)]

When the DISABLE_LDAP build flag is set, the xpfe/bootstrap directory will not
build because 'nsldap32v40.lib' unconditionally referenced in the makefile...

Comment 1

[rpotts (gone)]

hey chris,

it looks like you added 'nsldap32v40.lib' as a required library to
xpfe/bootstrap...  i'm assuming that this is required for static builds ??

if so, i'd like to place it inside of an !ifndef DISABLE_LDAP block so we can
build the tree without LDAP turned on (again)

-- rick

Comment 2

[Chris Waterson]

Yes, sorry -- I wasn't aware of DISABLE_LDAP builds. Patch coming up.

Comment 3

[Chris Waterson]

Attachment: don't link with ldap libs if DISABLE_LDAP set

Comment 4

[rpotts (gone)]

hey chris,

since you made the patch... i'll happily review it :-)

r=rpotts

Comment 5

[rpotts (gone)]

sr=[e-mail]

Comment 6

[rpotts (gone)]

Hey Chris,

Do we need to worry about patches for Makefile.in (unix) and, god forbid, the Mac?

-- rick

Comment 7

[Chris Waterson]

re: mac & linux, not sure about Mac; looks like Makefile.in already
conditionalizes ldap libs.

Comment 8

[rpotts (gone)]

yep...  

i noticed that Makefile.in conditionally includes the ldap libraries based on
'MOZ_LDAP_XPCOM'...

is that equivalent to 'DISABLE_LDAP' ?  

Never mind ;-)  I just noticed that 'DISABLE_LDAP' is a windows-only build flag...

Comment 9

[Chris Waterson]

Fix checked in.

Comment 10

[Ferdinand]

*** Bug 97036 has been marked as a duplicate of this bug. ***

Comment 11

[rpotts (gone)]

chris... this needs to be checked into the 0.9.2 branch as well (for embedding 
customers).

Do you want to?  or shall i?

-- rick

Comment 12

[Chris Waterson]

Checked in on mozilla-0.9.2 branch.

Comment 13

[rpotts (gone)]

This patch needs to be checked into the 0.9.4 branch too :-)

Comment 14

[rpotts (gone)]

I've just pushed this into the 0.9.4 branch too :-)

closing (again)!!

Comment 15

[sairuh (rarely reading bugmail)]

rs vrfy