Closed Bug 988475 Opened 6 years ago Closed 6 years ago

Rename IonFrame_* enum to JitFrame_*

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
There's some simple cleanup and renaming I'd like to do before the next ESR. This patch renames the IonFrame_* enum values to JitFrame_*, as they're used by both JITs. Also changes JitFrame_OptimizedJS to JitFrame_IonJS.
Attachment #8397272 - Flags: review?(nicolas.b.pierron)
Comment on attachment 8397272 [details] [diff] [review]
Patch

Review of attachment 8397272 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/vm/Stack.cpp
@@ +686,5 @@
>  
>  FrameIter::FrameIter(const Data &data)
>    : data_(data)
>  #ifdef JS_ION
> +    , ionInlineFrames_(data.cx_, data_.ionFrames_.isIonJS() ? &data_.ionFrames_ : nullptr)

style-nit: wile you are editing this line, remove extra indentation.
Attachment #8397272 - Flags: review?(nicolas.b.pierron) → review+
https://hg.mozilla.org/mozilla-central/rev/96788413092c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.