988539 - client-side make details when loading an edit route won't work for "not searchable" makes

Status: RESOLVED FIXED

(Webmaker Graveyard :: Thimble, defect)

Description

[Pomax]

you can't search for not-searchable makes, so saving a project as "not searchable" will make Thimble ask the makeapi for details and get nothing back. We'll need to make thimble request the makeapi details upon page generation time, so we can nunjucks it into the friendlycode loader.

Comment 1

[Pomax]

I rewrote the code to do server-side make loading instead, but searching for makes with the "searchable on webmaker.org" turned off (published = false) still doesn't yield any make details, despite the thimble user being authenticated as the 'owner'.

Comment 2

[Pomax]

Attachment: https://github.com/mozilla/thimble.webmaker.org/pull/407

this could should work, in principle, but a logged in user X, having published a make with "publish:false" to the makeapi, will not get any results back when searching for their make by url. This is despite thimble being hawk-authenticated with the makeapi.

The code in this attachment is code that *should* work, but doesn't, can you check whether there is an obviously missing bit here? (auth is set up in lib/makeapi, and the details are grabbed in lib/parameters for the :id parameter)

Comment 3

[Pomax]

STR:

- load thimble
- publish, with a random title, tags, and description, and with "searchable" turned on
- reload the page, with the /edit link
- republish. the fields should all be correct wrt what you fille in earlier, but this time turn off "searchable".
- reload the page, again with the /edit link
- republish. the fields are now "Defaults" because no makedetails were found for the make.

the node console will show the user's session, make url, and found makedetails in the console. The first two will be actual content, the third will be an empty array when the make is set to published:false in the makeapi.

It looks like the makeapi is not letting thimble see not-published makes, even when the correct user is logged in (although the hawk-auth may not have communicated that fact)

Comment 4

[Chris DeCairos (:cade)]

Looking at the Make API server logs, it seems that for some reason Thimble is not using the authenticated search route.

I suggest updating the client to 0.5.21 and using an unauthenticated instance for other searches and an authenticated one for that searches for finding unpublished makes - unless the only use for searching is authenticated.

Comment 5

[Pomax]

Comment on attachment 8398792 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/407

proper PR this time. The solution loads make details even on an edit/remix for a non-searchable make, and the checkbox in the publish details pane now also has the right value. unchecking it, saving (or cancelling), and then trying to publish again should now show the checkbox as still unchecked. Conversely, a not-searchable make should have the checkbox state persist during the session instead of resetting to checked.