Closed
Bug 988569
Opened 10 years ago
Closed 10 years ago
Should not suggest/insert completion results unnecessarily
Categories
(DevTools :: Source Editor, defect)
DevTools
Source Editor
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 31
People
(Reporter: Optimizer, Assigned: Optimizer)
Details
Attachments
(1 file, 1 obsolete file)
1.63 KB,
patch
|
harth
:
review+
|
Details | Diff | Splinter Review |
Right now the suggestion appears at many times it should not, like pressing shortcuts (ctrl - z etc), hitting enter in some cases, pressing space in the middle of , say, linear-gradient. Also, the suggestion is inserted when you press TAB in the value field. This is really irritating. Most of them are a result of bug 984141
Assignee | ||
Comment 1•10 years ago
|
||
Some minor fixes: Do not show suggestions popup upon hitting Enter while in css value area. Do not show suggestions popup when hitting some shortcuts using modifiers. try : https://tbpl.mozilla.org/?tree=Try&rev=c223e7c1ab30
Attachment #8409106 -
Flags: review?(fayearthur)
Assignee | ||
Comment 2•10 years ago
|
||
Turns out that while hitting Ctrl + Space, first Ctrl gets pressed then the combo. Ctrl leave the private.doNotAutocomplete as true, which effects Ctrl + Space combo too. Fixed. New try : https://tbpl.mozilla.org/?tree=Try&rev=98822b44956a
Attachment #8409106 -
Attachment is obsolete: true
Attachment #8409106 -
Flags: review?(fayearthur)
Attachment #8409311 -
Flags: review?(fayearthur)
Updated•10 years ago
|
Attachment #8409311 -
Flags: review?(fayearthur) → review+
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/fd8dd096ffe4
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fd8dd096ffe4
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 31
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•