Closed Bug 988569 Opened 6 years ago Closed 5 years ago

Should not suggest/insert completion results unnecessarily

Categories

(DevTools :: Source Editor, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 31

People

(Reporter: Optimizer, Assigned: Optimizer)

Details

Attachments

(1 file, 1 obsolete file)

Right now the suggestion appears at many times it should not, like pressing shortcuts (ctrl - z etc), hitting enter in some cases, pressing space in the middle of , say, linear-gradient.

Also, the suggestion is inserted when you press TAB in the value field. This is really irritating.

Most of them are a result of bug 984141
Attached patch minor-fixes (obsolete) — Splinter Review
Some minor fixes:

Do not show suggestions popup upon hitting Enter while in css value area.
Do not show suggestions popup when hitting some shortcuts using modifiers.

try : https://tbpl.mozilla.org/?tree=Try&rev=c223e7c1ab30
Attachment #8409106 - Flags: review?(fayearthur)
Attached patch minor-fixes-2Splinter Review
Turns out that while hitting Ctrl + Space, first Ctrl gets pressed then the combo. Ctrl leave the private.doNotAutocomplete as true, which effects Ctrl + Space combo too.

Fixed.

New try : https://tbpl.mozilla.org/?tree=Try&rev=98822b44956a
Attachment #8409106 - Attachment is obsolete: true
Attachment #8409106 - Flags: review?(fayearthur)
Attachment #8409311 - Flags: review?(fayearthur)
Attachment #8409311 - Flags: review?(fayearthur) → review+
Thanks Heather :)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/fd8dd096ffe4
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 31
QA Whiteboard: [qa-]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.