Closed Bug 988570 Opened 10 years ago Closed 10 years ago

nsXBLBinding::mUsingXBLScope is uninitialized with the second ctor

Categories

(Core :: XBL, defect)

24 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla31
Tracking Status
firefox28 --- wontfix
firefox29 --- wontfix
firefox30 --- wontfix
firefox31 --- fixed
firefox-esr24 --- unaffected

People

(Reporter: mccr8, Assigned: mccr8)

Details

(Keywords: sec-other, Whiteboard: [adv-main31-][qa-])

Bug 911864 added this new field, and then bug 806506 landed soon after and added a new ctor, but it doesn't set this field.  How bad of a problem is this?  (I'm investigating an intermittent leak that seems to happen in dom/tests/mochitest/webcomponents/test_nested_content_element.html.)
Flags: needinfo?(bobbyholley)
I think this is probably fine, because we set it unconditionally in SetBoundElement, which is where bindings are applied. So I think this isn't a security issue, but should still be fixed. r=me on a patch that initializes it on the other constructor.
Flags: needinfo?(bobbyholley)
Assignee: nobody → continuation
Keywords: sec-other
https://hg.mozilla.org/mozilla-central/rev/ddc17f82b758

Does this need uplifted anywhere?
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: needinfo?(continuation)
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
> Does this need uplifted anywhere?

It doesn't seem like it.
Flags: needinfo?(continuation)
Whiteboard: [adv-main31-]
Marking [qa-] due to lack of test case or STR. Please feel free to ask for verification if you have something for us to test with. Thank you.
Whiteboard: [adv-main31-] → [adv-main31-][qa-]
Group: core-security → core-security-release
Group: core-security-release
You need to log in before you can comment on or make changes to this bug.