'border-image' layout is wrong for fragmented boxes

VERIFIED FIXED in Firefox 32

Status

()

defect
P4
normal
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: mats, Assigned: mats)

Tracking

({testcase})

unspecified
mozilla32
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox32 verified)

Details

Attachments

(3 attachments, 2 obsolete attachments)

Assignee

Description

5 years ago
Posted file Testcase #1 (obsolete) —
It looks like the current layout would be correct for 'box-decoration-break:clone'
but the default should be 'slice'.

STR
Load the attached testcase.

ACTUAL RESULTS
Borders are drawn on all sides.

EXPECTED RESULTS
For the fragmented block at the top: there should be no border at the bottom edge
in the first column, nor at the top of the second column.  The left and right
borders of the second fragment should render as if continued below the first
fragment.
For the inline element at the bottom: there should be no right border on the
"a" fragment, and no left border on the "b" fragment.  The top/bottom border
of "b" should render as if it were part of "a", on the right side.

I think bug 613659 provides all supporting code for fixing this bug.
Assignee

Comment 1

5 years ago
Posted file Testcase #1, v2
Attachment #8397490 - Attachment is obsolete: true
Assignee

Comment 3

5 years ago
Posted patch WIP (obsolete) — Splinter Review
https://tbpl.mozilla.org/?tree=Try&rev=dc64e822b399
Assignee: nobody → matspal
Assignee

Comment 4

5 years ago
(note to self: cyan/lime is hard to tell apart for small sizes)
Assignee

Comment 5

5 years ago
Posted patch fix + reftestSplinter Review
Pretty straight-forward fix.  The hard part was writing the test; it seems
we have some pixel-rounding differences between platforms in the border-image
or GFX code.  The b-d-b Layout code is platform agnostic so I think
restricting the test to Linux is good enough to test that.

https://tbpl.mozilla.org/?tree=Try&rev=9d90ca00606b
https://tbpl.mozilla.org/?tree=Try&rev=594647d332f9
Attachment #8397573 - Attachment is obsolete: true
Attachment #8398842 - Flags: review?(cam)
Comment on attachment 8398842 [details] [diff] [review]
fix + reftest

Can you please clean up the inconsistent use of (and the few instances of trailing) white space in the <style> elements of the test/reference files.  It's rather messy. :)
Attachment #8398842 - Flags: review?(cam) → review+
Assignee

Comment 7

5 years ago
Cleaned up the test and pushed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8a8c87fcd2d9
Flags: in-testsuite+
https://hg.mozilla.org/mozilla-central/rev/8a8c87fcd2d9
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Assignee

Comment 9

5 years ago
Backed out on m-c:
remote:   https://hg.mozilla.org/mozilla-central/rev/581208970e99
remote:   https://hg.mozilla.org/mozilla-central/rev/ea214ef03c3f
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee

Comment 10

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/75cafc47ff36
Target Milestone: mozilla31 → mozilla32
https://hg.mozilla.org/mozilla-central/rev/75cafc47ff36
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
Verified fixed 32.0a1 (2014-05-08), Win 7 x64
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.