988661 - Implement enable addon debugging option in Toolbox

Status: RESOLVED FIXED

(DevTools :: Framework, defect)

Description

[Jordan Santell [:jsantell] [@jsantell]]

Implement an option to "Enable addon debugging" alongside chrome and remote debugging in toolbox options

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

https://tbpl.mozilla.org/?tree=Try&rev=e57331a67240

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 988661-enable-addon-debugging.patch

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8397934 [details] [diff] [review]
988661-enable-addon-debugging.patch

Review of attachment 8397934 [details] [diff] [review]:
-----------------------------------------------------------------

Well, the patch itself looks fine...

But, let's fold this into the chrome debugging pref, since that's likely the same user base and it's a similar functionality.

So, we'd update the label on the chrome pref to say something like "Enable chrome and addon debugging" and then you'd need to test that pref instead.

::: browser/locales/en-US/chrome/browser/devtools/toolbox.dtd
@@ +69,4 @@
>  <!ENTITY options.enableRemote.label3    "Enable remote debugging">
>  <!ENTITY options.enableRemote.tooltip   "Turning this option on will allow the developer tools to debug remote Firefox instance like Firefox OS">
>  
> +<!-- LOCALIZATION NOTE (options.enableAddon.label3): This is the label for the

Nit: Drop the "3" everywhere.

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 988661-enable-addon-debugging.patch

Now using `devtools.chrome.enabled` for all of addon debugger, and changed verbiage on the checkbox in the options

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

https://tbpl.mozilla.org/?tree=Try&rev=faa45bb5678f

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8398075 [details] [diff] [review]
988661-enable-addon-debugging.patch

Review of attachment 8398075 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/locales/en-US/chrome/browser/devtools/toolbox.dtd
@@ +59,5 @@
>  
>  <!-- LOCALIZATION NOTE (options.enableChrome.label3): This is the label for the
>    -  checkbox that toggles chrome debugging, i.e. devtools.chrome.enabled
>    -  boolean preference in about:config, in the options panel. -->
> +<!ENTITY options.enableChrome.label3    "Enable chrome and addon debugging">

We have to change the string IDs when the text changes...  So label3 -> label4 I guess.

@@ +60,5 @@
>  <!-- LOCALIZATION NOTE (options.enableChrome.label3): This is the label for the
>    -  checkbox that toggles chrome debugging, i.e. devtools.chrome.enabled
>    -  boolean preference in about:config, in the options panel. -->
> +<!ENTITY options.enableChrome.label3    "Enable chrome and addon debugging">
> +<!ENTITY options.enableChrome.tooltip   "Turning this option on will allow you to use various developer tools in browser context and debug addons from the Add-On Manager">

tooltip -> tooltip2

Comment 7

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 988661-enable-addon-debugging.patch

nits fixed

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/3bc0725093c5

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3bc0725093c5