Closed
Bug 988718
Opened 11 years ago
Closed 11 years ago
nsSecurityHeaderParser constructor should be marked explicit
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: Benjamin, Unassigned)
Details
Attachments
(1 file)
|
1008 bytes,
patch
|
keeler
:
review+
|
Details | Diff | Splinter Review |
A little C++ housekeeping.
Attachment #8397597 -
Flags: review?(dkeeler)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 8397597 [details] [diff] [review]
shp-exp.patch
Review of attachment 8397597 [details] [diff] [review]:
-----------------------------------------------------------------
I don't have a problem with this. I am curious as to why it's particularly important, however.
Attachment #8397597 -
Flags: review?(dkeeler) → review+
|
Reporter | |
Comment 2•11 years ago
|
||
It's not critical, of course, but it prevents implicit coercion from char *.
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a8f7aabfeb6
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•