988731 - [Tarako] Camera preview can not be used via Contacts AP.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[shawn ku [:sku]]

Attachment: Camera preview can not be used via Contacts app

Camera preview can not be used by following STR.

1. Launch Contacts
2. Add contact
3. Add picture
4. Camera

gaia
commit 386f4ac5c3db2ec562405c04c1ba33ede3bbf479

// Log
01-02 15:28:52.910    81    81 E [Gralloc-ERROR]: int gralloc_unregister_buffer(const gralloc_module_t*, const native_handle_t*):274 Trying to unregister buffer 0x47137150 from process 81 that was not created in current process: 81
01-02 15:28:53.070  1105  1105 E GeckoConsole: Content JS INFO at app://communications.gaiamobile.org/contacts/gaia_build_defer_index.js:228 in init: FB Already migrated!!!
01-02 15:28:53.130    81    81 E GeckoConsole: [JavaScript Error: "Content Security Policy: Can't use 'self' if self data is not provided"]
01-02 15:28:53.130    81    81 E GeckoConsole: [JavaScript Warning: "Content Security Policy: Failed to parse unrecognized source app://communications.gaiamobile.org"]
01-02 15:28:53.130    81    81 E GeckoConsole: [JavaScript Error: "Content Security Policy: Can't use 'self' if self data is not provided"]
01-02 15:28:53.140    81    81 E GeckoConsole: [JavaScript Warning: "Content Security Policy: Failed to parse unrecognized source app://communications.gaiamobile.org"]
01-02 15:28:53.150    81    81 E GeckoConsole: [JavaScript Error: "Content Security Policy: Can't use 'self' if self data is not provided"]
01-02 15:28:53.150    81    81 E GeckoConsole: [JavaScript Warning: "Content Security Policy: Failed to parse unrecognized source app://communications.gaiamobile.org"]
01-02 15:28:53.160    81    81 E GeckoConsole: [JavaScript Error: "Content Security Policy: Can't use 'self' if self data is not provided"]
01-02 15:28:53.160    81    81 E GeckoConsole: [JavaScript Warning: "Content Security Policy: Failed to parse unrecognized source app://communications.gaiamobile.org"]

Comment 1

[shawn ku [:sku]]

Hi Fabrice,
 Could you please help check this issue?

Two devices here, (one w/ chains patch, one w/o it.)
W/ chains patch,  camera preview via contacts AP can not work.
W/o chains patch, camera preview via contacts AP works ok.

Comment 2

[Joe Cheng [:jcheng] (please needinfo)]

Triage: regression 1.3T+
to Fabrice as bug 982491 was provided by Fabrice

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

This can be fixed by backing out bug 982491, for now.

Comment 4

[Mike Habicher [:mikeh] (high bugzilla latency)]

Here's the condition that's failing:

https://github.com/thesawolf/android_device_rockchip_rk3188/blob/master/libs/gralloc/gralloc_module.cpp#L203

Comment 5

[Mike Habicher [:mikeh] (high bugzilla latency)]

What device is this happening on?

Comment 6

[[:fabrice] Fabrice Desré]

(In reply to Mike Habicher [:mikeh] from comment #5)
> What device is this happening on?

A tarako

Comment 7

[[:fabrice] Fabrice Desré]

Ok, so logcat tells us that we fail because of:

D/SprdCameraHardware(   86): HAL_getCameraInfo: property_atv: 0.
E/gonkperm(12402): android.permission.CAMERA for pid=12528,uid=22528 denied: missing group
W/ServiceManager(   86): Permission failure: android.permission.CAMERA from uid=22528 pid=12528
E/CameraService(   86): Permission Denial: can't use the camera pid=12528, uid=22528

Comment 8

[Mike Habicher [:mikeh] (high bugzilla latency)]

This is removed in b2g-inbound: http://hg.mozilla.org/integration/b2g-inbound/rev/acf4ff844653#l4.164

Comment 9

[Sotaro Ikeda [:sotaro]]

The following log is actually not a error. It seems better to remove this log. It makes developers confusing.

> [Gralloc-ERROR]: int gralloc_unregister_buffer(const gralloc_module_t*, const native_handle_t*)


gralloc_unregister_buffer() is call when android::GraphicBuffer owns a handle not buffer. When GraphicBuffer is delivered via IPC, the handle is set to android::GraphicBuffer by GraphicBuffer::unflatten(). In this case, graphic buffer does not have a ownership of the buffer, only own handle.

Code in Comment 4 is just not to unmap gralloc buffer if the GraphicBuffer is allocated by same process. It typically happens when IPC client is in b2g process like drawing by system app.

Comment 10

[[:fabrice] Fabrice Desré]

The issue is fixed by uplifting bug 976839 and bug 976398. I'll ask 1.3t approvals there.

Comment 11

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Verified fixed in today's build


1.3t Environmental Variables:
Device: Tarako 1.3t
BuildID: 20140429014002
Gaia: b5adc5a943d3abbd6ab070a47c847f2c24891cc5
Gecko: e9890f5d4709
Version: 28.1
Firmware Version: sp6821

Comment 12

[Paladin]

According to comment #11, change Status to "verified".

Comment 13

[chaofei.wu]

remake[about_RAM_performance]

Comment 14

[Shally Li（leave from Mozilla）]

Per Comment 11,clear "verifyme".