988735 - Holiday calendar for South Africa 2013-2021

Status: RESOLVED FIXED

(Calendar :: Website, defect)

Description

[Malcolm McLean]

Attachment: SouthAfricaHolidays.ics

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 (Beta/Release)
Build ID: 20140306171728

Steps to reproduce:

Updated calendar file for South African holidays for 2013-2021, including new public holiday on 7 May 2014 for SA general election day.

Comment 1

[Malcolm McLean]

This calendar updates adds the new once-off public holiday on the 7th of May 2014 that is 3 weeks away (as well as updating to 2021)

When will this update be applied so everyone using the calendar can also get the new public holiday?

Comment 2

[Philipp Kewisch [:Fallen][📱📆]]

https://github.com/mozilla/bedrock/pull/2169

Comment 3

[Malcolm McLean]

Who updates the webpage at https://www.mozilla.org/en-US/projects/calendar/holidays/? The South African calendar is still listed as 2012-2015 instead of 2013-2021.

(I suppose this would also apply to the other calendars in the same commit too).

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

Sorry, it seems I forgot to update the .json file, I believe I've fixed it for the other calendars though. I will take a look.

Comment 5

[Malcolm McLean]

I see the website still says 2012-2015 for the South African calendar, although this is actually for 2013-2021

Comment 6

[Philipp Kewisch [:Fallen][📱📆]]

I should have set myself for needinfo, thanks for the reminder. Here is the pull request to fix it:

https://github.com/mozilla/bedrock/pull/3334

Comment 7

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/ccad9e68fca318ae19dae3faabf24d05536de807
Bug 988735 - Fix year for South Africa holidays

https://github.com/mozilla/bedrock/commit/262d3741402b33b6fe217f9deb8113ab7c470b1f
Merge pull request #3334 from kewisch/caldata-sa-year

Bug 988735 - Fix year for South Africa holidays