Closed Bug 988774 Opened 6 years ago Closed 6 years ago

Reenable sccache on android builds

Categories

(Firefox Build System :: General, defect)

All
Android
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla31

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(3 files)

I just figured bug 933189 broke that.
Attached file setup.sh
Rail, could you put this file on tooltool? Thanks.
Attachment #8397711 - Flags: checkin?(rail)
Attachment #8397732 - Flags: review?(trev.saunders)
no_tooltool is defined in all builds that don't use tooltool (and thus wouldn't have sccache).
Attachment #8397736 - Flags: review?(bhearsum)
Attachment #8397732 - Flags: review?(trev.saunders) → review+
> no_tooltool is defined in all builds that don't use tooltool (and thus
> wouldn't have sccache).

it looks like that's not true for mac or win  l10n mozconfigs, maybe they actually have tooltool, but then why do the linux l10n mozconfigs have no_tooltool=1?
Comment on attachment 8397711 [details]
setup.sh

size: 288
sha512: 9638d15cf076a7e6cfa304a2aae13579657e34391f38e1224afe10f2755f6f379823b83d84f19811c1076b35b96aa420d1749f49712a2a35149387d98bd62ea0
Attachment #8397711 - Flags: checkin?(rail) → checkin+
crap, I just bitrotted you here Mike....

Specifically by adding an extra thing to setup.sh in Bug 971841

I'll be free tomorrow to upload a corrected setup.sh from here for you, and to do a quick r+ of the in-tree patch.
Yay, one more reason for bug 988785
(In reply to Justin Wood (:Callek) from comment #6)
> crap, I just bitrotted you here Mike....

people.mozilla.org/~tsaunders/setup.sh.sdk should merge correctly
setup.sh.sdk of size 335 uploaded to tooltool with sha512sum of:

2f0e2f345b39789e24de032a156c53d1895c69b525d661c57d208fd528e22694841213a06f52e70fac17b9161e107c581260d95dacda0a5710b90d57668dc895

Please don't land until after the patch in Bug 971841 lands (hopefully as soon as trees open that will land)
Whiteboard: [leave open]
Comment on attachment 8397736 [details] [diff] [review]
Do not gracefully disable sccache when it's not there

Review of attachment 8397736 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay, I thought I reviewed this yesterday!
Attachment #8397736 - Flags: review?(bhearsum) → review+
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [leave open]
Target Milestone: --- → mozilla31
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.