988804 - B2GPerfScrollMessagesTest is failing on inari

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

This test has been failing for a while on inari, and now that I have an inari to test on I can see it's because the wait is not entirely appropriate for the slower device.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Link to Github pull-request: https://github.com/mozilla/b2gperf/pull/47

I've included a version bump so we can release it to PyPI.

Comment 2

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8397759 [details] [review]
Link to Github pull-request: https://github.com/mozilla/b2gperf/pull/47

Interesting we have to wait for the element to be present, and then to be displayed.

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

It's possible we don't need to wait for it to be displayed, as this will likely happen at the same time as it's present. We do however want it to be displayed before we interact with it, so it's worth the extra wait to make the test robust.

Landed in:
https://github.com/mozilla/b2gperf/commit/29593a029bddaeb65856d5b3694c9933bb5da485

I decided not to include the version bump, as it looks like there may be at least one other fix we'll need to pick up.