988849 - Add mach target for jit tests

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Dan Minor [:dminor]]

We're planning to remove jittests from 'make check' in bug 988532.

Although the tests are easy to run, it would be good to provide a mach target that matches the arguments currently passed into the tests as part of make check.

Comment 1

[Dan Minor [:dminor]]

Attachment: Add mach target for jit tests

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8397834 [details] [diff] [review]
Add mach target for jit tests

Review of attachment 8397834 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

::: testing/mach_commands.py
@@ +223,5 @@
> +            js = os.path.join(self.bindir, 'js.exe')
> +        else:
> +            js = os.path.join(self.bindir, 'js')
> +        cmd = [os.path.join(self.topsrcdir, 'js', 'src', 'jit-test', 'jit_test.py'),
> +              js, '--no-slow', '--no-progress', '--tinderbox', '--tbpl']

Why --no-progress?

Comment 3

[Dan Minor [:dminor]]

Thanks, pushed to https://hg.mozilla.org/integration/mozilla-inbound/rev/12fbb6719ce9

The --no-progress flag suppresses an ascii progress bar. Together with --tinderbox, it generates TBPL style output. I thought it made sense to match what 'make check' does with this command.

Comment 4

[(not currently active) Ted Mielczarek]

nit-picky, but I'd probably just get rid of --no-progress and have --tinderbox imply that. I don't care strongly enough to make you change your patch though.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/12fbb6719ce9