Closed Bug 988849 Opened 6 years ago Closed 6 years ago

Add mach target for jit tests

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla31

People

(Reporter: dminor, Assigned: dminor)

References

Details

Attachments

(1 file)

We're planning to remove jittests from 'make check' in bug 988532.

Although the tests are easy to run, it would be good to provide a mach target that matches the arguments currently passed into the tests as part of make check.
Assignee: nobody → dminor
Status: NEW → ASSIGNED
Attachment #8397834 - Flags: review?(gps)
Comment on attachment 8397834 [details] [diff] [review]
Add mach target for jit tests

Review of attachment 8397834 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

::: testing/mach_commands.py
@@ +223,5 @@
> +            js = os.path.join(self.bindir, 'js.exe')
> +        else:
> +            js = os.path.join(self.bindir, 'js')
> +        cmd = [os.path.join(self.topsrcdir, 'js', 'src', 'jit-test', 'jit_test.py'),
> +              js, '--no-slow', '--no-progress', '--tinderbox', '--tbpl']

Why --no-progress?
Attachment #8397834 - Flags: review?(gps) → review+
Thanks, pushed to https://hg.mozilla.org/integration/mozilla-inbound/rev/12fbb6719ce9

The --no-progress flag suppresses an ascii progress bar. Together with --tinderbox, it generates TBPL style output. I thought it made sense to match what 'make check' does with this command.
nit-picky, but I'd probably just get rid of --no-progress and have --tinderbox imply that. I don't care strongly enough to make you change your patch though.
https://hg.mozilla.org/mozilla-central/rev/12fbb6719ce9
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.