Closed
Bug 988849
Opened 10 years ago
Closed 10 years ago
Add mach target for jit tests
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla31
People
(Reporter: dminor, Assigned: dminor)
References
Details
Attachments
(1 file)
2.11 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
We're planning to remove jittests from 'make check' in bug 988532. Although the tests are easy to run, it would be good to provide a mach target that matches the arguments currently passed into the tests as part of make check.
Assignee | ||
Comment 1•10 years ago
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8397834 [details] [diff] [review] Add mach target for jit tests Review of attachment 8397834 [details] [diff] [review]: ----------------------------------------------------------------- LGTM. ::: testing/mach_commands.py @@ +223,5 @@ > + js = os.path.join(self.bindir, 'js.exe') > + else: > + js = os.path.join(self.bindir, 'js') > + cmd = [os.path.join(self.topsrcdir, 'js', 'src', 'jit-test', 'jit_test.py'), > + js, '--no-slow', '--no-progress', '--tinderbox', '--tbpl'] Why --no-progress?
Attachment #8397834 -
Flags: review?(gps) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Thanks, pushed to https://hg.mozilla.org/integration/mozilla-inbound/rev/12fbb6719ce9 The --no-progress flag suppresses an ascii progress bar. Together with --tinderbox, it generates TBPL style output. I thought it made sense to match what 'make check' does with this command.
Comment 4•10 years ago
|
||
nit-picky, but I'd probably just get rid of --no-progress and have --tinderbox imply that. I don't care strongly enough to make you change your patch though.
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/12fbb6719ce9
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•