988904 - Stop creating a Thebes gfxImageSurface in PresShell::PaintRangePaintInfo

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jonathan Watt [:jwatt]]

We should stop creating a Thebes gfxImageSurface in PresShell::PaintRangePaintInfo.

Comment 1

[Jonathan Watt [:jwatt]]

When we create a visual selection, it is then displayed on the screen. We should really be using gfxPlatform::CreateOffscreenContentDrawTarget, I think.

Comment 2

[Jonathan Watt [:jwatt]]

(If this really needs to be a data/CAIRO backed DrawTarget for some reason, then we can do something like:

  int32_t stride = pixelArea.width * BytesPerPixel(SurfaceFormat::B8G8R8A8);
  nsAutoArrayPtr<uint8_t> data = new uint8_t[stride * pixelArea.height];
  if (!data) {
    return nullptr;
  }
  RefPtr<DrawTarget> dt =
    Factory::CreateDrawTargetForData(BackendType::CAIRO,
                                     data,
                                     IntSize(pixelArea.width, pixelArea.height),
                                     stride,
                                     SurfaceFormat::B8G8R8A8);
  if (!dt) {
    return nullptr;
  }
  dt->Clear(Rect(0, 0, pixelArea.width, pixelArea.height));

.)

Comment 3

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 4

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/97ea4b50ee3a

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/97ea4b50ee3a