Closed
Bug 988931
Opened 9 years ago
Closed 9 years ago
Fix some race conditions in the devtools.
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 31
People
(Reporter: janx, Assigned: janx)
References
Details
Attachments
(1 file)
1.70 KB,
patch
|
ochameau
:
review+
|
Details | Diff | Splinter Review |
Sometimes when some files are loaded too early, race conditions happen. For instance, if `toolkit/devtools/server/child.js` is loaded too early, `Cu` might not be defined. If `toolkit/devtools/server/main.js` is loaded too early, `Promise` is not defined, and so on. This caused an intermittent failure in the gaia integration tests, so we should fix at least those two races.
Assignee | ||
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8397909 [details] [diff] [review] Fix some race conditions in the devtools. r=ochameau Alex, may I ask for your stamp of approval?
Attachment #8397909 -
Flags: review?(poirot.alex)
Comment 3•9 years ago
|
||
Comment on attachment 8397909 [details] [diff] [review] Fix some race conditions in the devtools. r=ochameau Review of attachment 8397909 [details] [diff] [review]: ----------------------------------------------------------------- Looks like we should really do something about actors scope being merged with DebuggerServer one...
Attachment #8397909 -
Flags: review?(poirot.alex) → review+
Assignee | ||
Comment 4•9 years ago
|
||
> Looks like we should really do something about actors scope being merged
> with DebuggerServer one...
Agreed!
Keywords: checkin-needed
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/951c1b3e799f
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/951c1b3e799f
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 31
Updated•4 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•