Closed Bug 988931 Opened 9 years ago Closed 9 years ago

Fix some race conditions in the devtools.

Categories

(DevTools :: General, defect)

Product:
DevTools
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 31

People

(Reporter: janx, Assigned: janx)

References

Details

Attachments

(1 file)

Fix some race conditions in the devtools. r=ochameau
1.70 KB, patch
ochameau
: review+
Details | Diff | Splinter Review 
Sometimes when some files are loaded too early, race conditions happen. For instance, if `toolkit/devtools/server/child.js` is loaded too early, `Cu` might not be defined. If `toolkit/devtools/server/main.js` is loaded too early, `Promise` is not defined, and so on.

This caused an intermittent failure in the gaia integration tests, so we should fix at least those two races.
Comment on attachment 8397909 [details] [diff] [review]
Fix some race conditions in the devtools. r=ochameau

Alex, may I ask for your stamp of approval?
Attachment #8397909 - Flags: review?(poirot.alex)
Comment on attachment 8397909 [details] [diff] [review]
Fix some race conditions in the devtools. r=ochameau

Review of attachment 8397909 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like we should really do something about actors scope being merged with DebuggerServer one...
Attachment #8397909 - Flags: review?(poirot.alex) → review+
> Looks like we should really do something about actors scope being merged
> with DebuggerServer one...

Agreed!
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/951c1b3e799f
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 31
Blocks: 990400
QA Whiteboard: [qa-]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.