988951 - archive.org initial media clips don't get the linkback param

Status: RESOLVED FIXED

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[Scott [:thecount] Downe]

When an initialMedia query string is used, we don't pass archive.org linkback urls to the media celip track event.

Comment 1

[tracey jaquith]

Attachment: linkback.patch

Comment 2

[Matthew Schranz [:mjschranz]]

Comment on attachment 8398103 [details] [diff] [review]
linkback.patch

The added line is missing a comma, but otherwise should be good.

Comment 3

[Scott [:thecount] Downe]

Comment on attachment 8398103 [details] [diff] [review]
linkback.patch

Yeah, just what Matt said.

I can fix that up during the merge if you like though.

Comment 4

[tracey jaquith]

sorry about that typo!  (got too cute moving it "up" for a 1-line diff and forgot the , hehe)

should i be editing the patch to that fix or anything i should be doing?

we launched TV version 2 today!!
(so "add to popcorn" button is now live all over our site, yay!!)

Comment 5

[tracey jaquith]

http://blog.archive.org/2014/04/01/tv-news-intro/

(In reply to tracey jaquith from comment #4)
> sorry about that typo!  (got too cute moving it "up" for a 1-line diff and
> forgot the , hehe)
> 
> should i be editing the patch to that fix or anything i should be doing?
> 
> we launched TV version 2 today!!
> (so "add to popcorn" button is now live all over our site, yay!!)

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org

https://github.com/mozilla/popcorn.webmaker.org/commit/4a662add4d066a13ec06c9b878a747c2cd6b3928
Fix bug 988951 - Initial media clips don't get attribution