Remove 'deprecated-hwvideo' from PermissionsTable.jsm

RESOLVED FIXED in 2.1 S5 (26sep)

Status

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mikeh, Assigned: mikeh)

Tracking

unspecified
2.1 S5 (26sep)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

This permission isn't used anywhere in the code, and bug 803471 removed the need for the Camera app to have special permissions to access the camera hardware, so we can remove this.
Posted patch no-deprecated-hwvideo.patch (obsolete) — Splinter Review
Assignee: nobody → fabrice
Attachment #8478698 - Flags: review?(mhabicher)
Hmm, looks like comment 0 might no longer be accurate:

# grep -rn "deprecated-hwvideo" *
apps/gallery/manifest.webapp:15:    "deprecated-hwvideo":{},
apps/settings/resources/permissions_table.json:39:    "deprecated-hwvideo",
apps/video/manifest.webapp:15:    "deprecated-hwvideo":{},
apps/video/js/video.js:81:// This app uses deprecated-hwvideo permission to access video decoding hardware
apps/music/manifest.webapp:14:    "deprecated-hwvideo":{},
Flags: needinfo?(fabrice)
I don't know if the gaia apps are still asking for this permission because we forgot to remove them, or if we really used these. There is no use in gecko of this permission anymore anyway, and I have anecdotal evidence that this doesn't prevent the apps from working. That would be great if you could double check though.
Flags: needinfo?(fabrice)
It looks like the 'deprecated-hwvideo' permission isn't used in any of the manifests anymore, but the PermissionsTable.jsm has moved. Updated patch.
Assignee: fabrice → mhabicher
Attachment #8478698 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8478698 - Flags: review?(mhabicher)
Attachment #8489609 - Flags: review?(fabrice)
Attachment #8489609 - Flags: review?(fabrice) → review+
https://hg.mozilla.org/mozilla-central/rev/224e8fb07a62
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S5 (26sep)
You need to log in before you can comment on or make changes to this bug.