989037 - [B2G][Video] In video app, share and trash icons have no highlight state

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Video, defect)

Description

[jcastro]

Attachment: ShareIcon_no_highlight.txt

Description:
User is in the video app with a few videos. Hit the selection button, select a video file. When the user hits the share or trash button, there is no highlight state as referenced in test case 11322, and here: https://bug947103.bugzilla.mozilla.org/attachment.cgi?id=8343589


Repro Steps:
1) Update a buri to BuildID: 20140326000201
2) Have a video saved
3) Open Video app
4) Hit selection icon > Select a video
5) Hit share icon

Actual:
Icon has no highlight state as described in test case 11322

Expected:
Icon has a highlight state when pushed

1.4 Environmental Variables:
Device: buri 1.4 MOZ
BuildID: 20140326000201
Gaia: 7e705dd4718d528974d99ac31866318d7e201152
Gecko: 4889124accfa
Version: 30.0a2
Firmware Version: v1.2-device.cfg

Repro frequency: 100%
Link to failed test case: 11322
See attached: video clip and logcat
https://www.youtube.com/watch?v=FBsdrw-h4bw&feature=youtu.be

Comment 1

[jcastro]

Bug is present in 1.3

1.3 Environmental Variables:
Device: buri 1.3 MOZ
BuildID: 20140326004002
Gaia: 812838ad0fabf51fa14435af562ddac6d26fa936
Gecko: ba97efb0da4b
Version: 28.0
Firmware Version: v1.2-device.cfg

Comment 2

[amitav.anand]

Attachment: PR

Added hight light state for delete and share icon

Comment 3

[Tiffanie Shakespeare [:tif]]

Hi Amitav! I'm actually not seeing the share and delete icon anymore. I just updated the master branch and video is now using the "more" icon to launch an action menu. 

David, did this new video UI get into 2.0 or is it just 2.1?

Here's my info from my flame:
Gaia      8af12a362080bb2e3b4997437c0078c7f3cfe3cf
Gecko     https://hg.mozilla.org/mozilla-central/rev/80431d4fd0da
BuildID   20140616040202
Version   33.0a1

Comment 4

[David Flanagan [:djf]]

Tif,

Yes, apparently the new header and options menu is in 2.0 and 2.1.  I didn't even know that was happening. I think it is too late to fix this in 1.4 and earlier releases so I suggest we resolve this WONTFIX or WORKSFORME.

Amitav: sorry for the lack of coordination on this bug. It looks like your patch is no longer needed.

Comment 5

[Tiffanie Shakespeare [:tif]]

Yes - sorry Amitav about the extra work, it doesn't look like we need it.

Would it make more sense it mark as invalid since the patch isn't needed for 2.0+?

Comment 6

[David Flanagan [:djf]]

Hmm. It looks like maybe Amitav's patch is relevant for the tablet form factor...  I don't know who is working on that and would be suitable to review it, however.

Amitav: did you create this patch with the tablet in mind?

Comment 7

[amitav.anand]

Hi David, I had fixed and tested this on Nexus4. Did'nt have a tablet with me. This fix works for nexus 4 atleast.

Comment 8

[Tiffanie Shakespeare [:tif]]

Comment on attachment 8439743 [details] [review]
PR

Clearing my flag as this isn't needed for the phone factor. I don't have a tablet to review it on.

Thank Amitav!

Comment 9

[amitav.anand]

Clearing my flag, as the fix is not needed :-)

Comment 10

[David Flanagan [:djf]]

Comment on attachment 8439743 [details] [review]
PR

clearing the review request and closing the bug since it is now obsolete