Closed
Bug 989071
Opened 11 years ago
Closed 11 years ago
Correct comment for nsIThreadRetargetableRequest.retargetDeliveryTo()
Categories
(Core :: Networking: WebSockets, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: sworkman, Assigned: sworkman)
Details
Attachments
(1 file)
|
1.62 KB,
patch
|
jduell.mcbugs
:
review+
|
Details | Diff | Splinter Review |
Follow up to bug 925623.
We need to change nsIThreadRetargetableRequest to mention when it's OK to call for websockets--there is no OnStartRequest, so instead we need language like "before AsyncOpen if a nsIWebsocketChannel, or during OnStartRequest for nsIHttpChannels)."
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8398120 -
Flags: review?(jduell.mcbugs)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8398120 [details] [diff] [review]
Correct comment for nsIThreadRetargetableRequest.retargetDeliveryTo()
Review of attachment 8398120 [details] [diff] [review]:
-----------------------------------------------------------------
::: netwerk/base/public/nsIThreadRetargetableRequest.idl
@@ +20,5 @@
> /**
> * Called to retarget delivery of OnDataAvailable to another thread. Should
> + * only be called before AsyncOpen for nsIWebsocketChannels, or during
> + * OnStartRequest for nsIHttpChannels.
> + * Note: OnStartRequest and OnStopRequest will still be delivered on the main
Note: for nsIHttpChannels, OnStartRequest and OnStopRequest will still be delivered on the main thread
Attachment #8398120 -
Flags: review?(jduell.mcbugs) → review+
|
|
||
Comment 3•11 years ago
|
||
Land this with DONTBUILD in the commit comment so we don't burn a try cycle on it.
|
|
Assignee | |
Comment 4•11 years ago
|
||
|
||
Comment 5•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•