989071 - Correct comment for nsIThreadRetargetableRequest.retargetDeliveryTo()

Status: RESOLVED FIXED

(Core :: Networking: WebSockets, enhancement)

Description

[Steve Workman [:sworkman] (INACTIVE)]

Follow up to bug 925623.

We need to change nsIThreadRetargetableRequest to mention when it's OK to call for websockets--there is no OnStartRequest, so instead we need language like "before AsyncOpen if a nsIWebsocketChannel, or during OnStartRequest for nsIHttpChannels)."

Comment 1

[Steve Workman [:sworkman] (INACTIVE)]

Attachment: Correct comment for nsIThreadRetargetableRequest.retargetDeliveryTo()

Comment 2

[Jason Duell]

Comment on attachment 8398120 [details] [diff] [review]
Correct comment for nsIThreadRetargetableRequest.retargetDeliveryTo()

Review of attachment 8398120 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/base/public/nsIThreadRetargetableRequest.idl
@@ +20,5 @@
>    /**
>     * Called to retarget delivery of OnDataAvailable to another thread. Should
> +   * only be called before AsyncOpen for nsIWebsocketChannels, or during
> +   * OnStartRequest for nsIHttpChannels.
> +   * Note: OnStartRequest and OnStopRequest will still be delivered on the main

Note: for nsIHttpChannels, OnStartRequest and OnStopRequest will still be delivered on the main thread

Comment 3

[Jason Duell]

Land this with DONTBUILD in the commit comment so we don't burn a try cycle on it.

Comment 4

[Steve Workman [:sworkman] (INACTIVE)]

Thanks Jason!

https://hg.mozilla.org/integration/mozilla-inbound/rev/a7355ddf5b01

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/a7355ddf5b01