989104 - [email] allow for longer module load timeouts for background loads

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[James Burke [:jrburke]]

An issue came up in Clock for Tarako, where the background loading of the alarm entry point was taking a long time, longer than the default 7 seconds used as the timeout for module loading. The fix mcav and I worked out is setting waitSeconds to 7 in DEBUG=1 scenarios, but in a build scenario, changing the value to 0, which means no timeout:

https://github.com/mozilla-b2g/gaia/pull/17587/files

We should probably do the same thing for email, particularly for Tarako and sync cases.

Comment 1

[James Burke [:jrburke]]

Attachment: GELAM pull request

Asking mcav for review since he did similar change for clock, but feel free to kick it back if you prefer not to do it.

Confirmed that output ends up with waitSeconds set to 0 for both front and back end, an run on device, still works.

Comment 2

[James Burke [:jrburke]]

Attachment: Gaia pull request

Asking mcav for review since he did similar change for clock, but feel free to kick it back if you prefer not to do it.

Confirmed that output ends up with waitSeconds set to 0 for both front and back end, an run on device, still works.

Comment 3

[Marcus Cavanaugh [:mcav]]

Comment on attachment 8398264 [details] [review]
GELAM pull request

It's like deja-vu all over again! :)

Comment 4

[Marcus Cavanaugh [:mcav]]

Comment on attachment 8398265 [details] [review]
Gaia pull request

I was confused for a second at the js/ext file showing 0, but realized it was copied from gelam. Looks ok to me.

Comment 5

[James Burke [:jrburke]]

Some background on that for completeness: I thought it was fine to use 0 for the copied built gelam as those layers are loaded in bulk optimized form inside the worker. Since the worker uses importScripts() which is synchronous, if there were errors, there should be a very obvious error without needing the script timeout in the loader.

Comment 6

[James Burke [:jrburke]]

Merged in gaia master:
https://github.com/mozilla-b2g/gaia/commit/4cf7ec04b82320a1ff1f825220204f454f951a87

from pull request:
https://github.com/mozilla-b2g/gaia/pull/17735

GELAM merge:
https://github.com/mozilla-b2g/gaia-email-libs-and-more/commit/2c2325b98fca30e72c4421d480354702b5fd6255

from pull request:
https://github.com/mozilla-b2g/gaia-email-libs-and-more/pull/295