989112 - libxul.so linking fails: GStreamerReader.cpp:1264: undefined reference to `gst_event_type_get_name' (--enable-gstreamer=1.0 --enable-debug)

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Jan Beich]

Attachment: hide for dlopen

content/media/gstreamer/GStreamerReader.o: In function `mozilla::GStreamerReader::EventProbe(_GstPad*, _GstEvent*)':
content/media/gstreamer/GStreamerReader.cpp:1264: undefined reference to `gst_event_type_get_name'
c++: error: linker command failed with exit code 1 (use -v to see invocation)
gmake[1]: *** [libxul.so] Error 1

before

$ objdump -t obj-*/content/media/gstreamer/GStreamerReader.o | fgrep gst_event_type_get_name
0000000000000000         *UND*  0000000000000000 gst_event_type_get_name

after

$ objdump -t --demangle obj-*/content/media/gstreamer/GStreamerReader.o | fgrep gst_event_type_get_name
0000000000000000         *UND*  0000000000000000 .hidden mozilla::gst_event_type_get_name

Comment 1

[Jan Beich]

Comment on attachment 8398179 [details] [diff] [review]
hide for dlopen

[Approval Request Comment]
Bug caused by (feature/regressing bug #): new feature regression in bug 806917
User impact if declined: --enable-gstreamer=1.0 --enable-debug broken build
Testing completed (on m-c, etc.): local, m-i defaults to --enable-gstreamer=0.10 atm
Risk to taking this patch (and alternatives if risky): None
String or IDL/UUID changes made by this patch: None

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/58dd10f21d5c

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/58dd10f21d5c

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/75e80eb818b7