Closed Bug 989145 Opened 6 years ago Closed 6 years ago

Convert ImageContainer::mBackendData to be an EnumeratedArray

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla31

People

(Reporter: bjacob, Assigned: bjacob)

References

Details

Attachments

(1 file)

Bug 989123 introduces a shiny new EnumeratedArray container to replace plain arrays when indexing by typed enums. Here is one simple use case for it.
Attachment #8398224 - Flags: review?(nical.bugzilla)
Comment on attachment 8398224 [details] [diff] [review]
Convert ImageContainer::mBackendData to be an EnumeratedArray

Review of attachment 8398224 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/ImageContainer.h
@@ +205,5 @@
>      return nsIntRect(0, 0, GetSize().width, GetSize().height);
>    }
>  
>    ImageBackendData* GetBackendData(LayersBackend aBackend)
> +  { return mBackendData[aBackend]; }

nit: I am tempted to ask you to fix the formatting here (braces on new lines) since you are touching that line.
Attachment #8398224 - Flags: review?(nical.bugzilla) → review+
https://hg.mozilla.org/mozilla-central/rev/a7a471cd3900
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.