Closed Bug 989203 Opened 11 years ago Closed 11 years ago

Fix and suppress some Android gcc warnings in media/omx-plugin/ directory

Categories

(Core :: Audio/Video, defect)

Product:
Core
Component:
Audio/Video
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla31
Tracking Flags:
Tracking Status
firefox30 --- wontfix
firefox31 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

fix-omx-plugin-warnings.patch
4.92 KB, patch
cajbir
: review+
Details | Diff | Splinter Review
media/omx-plugin/OmxPlugin.cpp:284:5 [-Wswitch] case value '2141391873' not in enumerated type 'OMX_COLOR_FORMATTYPE' media/omx-plugin/OmxPlugin.cpp:285:5 [-Wswitch] case value '2141391872' not in enumerated type 'OMX_COLOR_FORMATTYPE' media/omx-plugin/OmxPlugin.cpp:286:5 [-Wswitch] case value '2130706688' not in enumerated type 'OMX_COLOR_FORMATTYPE' media/omx-plugin/OmxPlugin.cpp:730:49 [-Wsign-compare] comparison between signed and unsigned integer expressions ... followed by 185 -Wmultichar warnings! media/omx-plugin/include/froyo/stagefright/MetaData.h:32:20 [-Wmultichar] multi-character character constant media/omx-plugin/include/froyo/stagefright/MetaData.h:33:17 [-Wmultichar] multi-character character constant media/omx-plugin/include/froyo/stagefright/MetaData.h:34:18 [-Wmultichar] multi-character character constant media/omx-plugin/include/froyo/stagefright/MetaData.h:35:24 [-Wmultichar] multi-character character constant media/omx-plugin/include/froyo/stagefright/MetaData.h:36:22 [-Wmultichar] multi-character character constant media/omx-plugin/include/froyo/stagefright/MetaData.h:37:22 [-Wmultichar] multi-character character constant ...
Attachment #8398335 - Flags: review?(cajbir.bugzilla)
Attachment #8398335 - Flags: review?(cajbir.bugzilla) → review?(cpearce)
Attachment #8398335 - Flags: review?(cpearce) → review+
https://hg.mozilla.org/mozilla-central/rev/cad6eb7eaf92
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: