Closed Bug 989217 Opened 11 years ago Closed 10 years ago

update the buglist link on release notes to be friendlier to bugzilla (and execute quicker)

Categories

(www.mozilla.org :: General, defect)

Production
x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: glob, Assigned: jgmize)

References

()

Details

(Whiteboard: [kb=1321888] )

Attachments

(1 file)

38 bytes, text/x-github-pull-request
Details | Review
https://www.mozilla.org/en-US/firefox/28.0/releasenotes/ links to bugzilla using the following url: https://bugzilla.mozilla.org/buglist.cgi?bug_status=RESOLVED&bug_status=VERIFIED&bug_status=CLOSED&f1=target_milestone&f2=cf_status_firefox28&f3=target_milestone&j_top=OR&o1=anywords&o2=anywords&o3=equals&query_format=advanced&resolution=FIXED&v1=mozilla28&v2=fixed%2Cverified&v3=Firefox%2028&order=bug_id&limit=0 this is slow (meaning it places more demand on database resources) due to the operators it uses: [target milestone] [contains any of the words] [mozilla28] [status-firefox28] [contains any of the words] [fixed,verified] [target milestone] [is equal to] [Firefox 28] "contains any of the words" means "match this whole word, but not substrings", however that's unnecessary in this instance. i propose the following query: https://bugzilla.mozilla.org/buglist.cgi?j_top=OR&f1=target_milestone&o3=equals&v3=Firefox%2028&o1=equals&resolution=FIXED&o2=anyexact&query_format=advanced&f3=target_milestone&f2=cf_status_firefox28&bug_status=RESOLVED&bug_status=VERIFIED&bug_status=CLOSED&v1=mozilla28&v2=fixed%2Cverified&limit=0 [target milestone] [is equal to] [mozilla28] [status-firefox28] [is equal to any of the strings] [fixed,verified] [target milestone] [is equal to] [Firefox 28] as an example of the differences, the status-firefox28 term using "contains any of the words" results in the following sql: ( ((INSTR(COALESCE(tracking_flags_bugs_3.value, '---'), 'fixed') > 0 AND COALESCE(tracking_flags_bugs_3.value, '---') REGEXP '(^|[^[:alnum:]])fixed($|[^[:alnum:]])') OR (INSTR(COALESCE(tracking_flags_bugs_3.value, '---'), 'verified') > 0 AND COALESCE(tracking_flags_bugs_3.value, '---') REGEXP '(^|[^[:alnum:]])verified($|[^[:alnum:]])')) ) while my proposed replacement results in: COALESCE(tracking_flags_bugs_3.value, '---') IN ('fixed','verified')
:lsblakk, how about I make :glob's suggested changes to the default query on the bedrock side? As a reminder, if you need to make any tweaks for a particular release you can still override the bug search url in the nucleus admin. Then as we finish porting from php to bedrock the older, less efficient queries will disappear from the site.
Flags: needinfo?(lsblakk)
WFM. Thanks for the feedback on optimizing!
Flags: needinfo?(lsblakk)
Assignee: nobody → jmize
Whiteboard: [kb=1321888]
Attached file rna pr 31
Commits pushed to master at https://github.com/mozilla/rna https://github.com/mozilla/rna/commit/925a094ba61344f1d35b5a59979f167dda4c96fc Optimize default bug_search_url for bug 989217 https://github.com/mozilla/rna/commit/b0a69ffa65f0c49b0d3b81ad478c36a5174c2aa8 Merge pull request #31 from jgmize/bugzilla-query-optimization Optimize default bug_search_url for bug 989217
Commits pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/7322f623944244cb99ab5f4d30bea3db88d2792b Upgrade rna submodule to fix bug 989217 https://github.com/mozilla/bedrock/commit/8d199683049eee80c47fe6499c875e9b05eaf77b Merge pull request #1932 from jgmize/bugzilla-query-optimization Upgrade rna submodule to fix bug 989217
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
thanks!
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: