989224 - Note orphaned FragmentOrElements in CC logs

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

It would be nice if this were obvious, rather than having to walk the parent chain manually.

It seems like <xbl:content> is never in a document, so I filtered those out.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Odd to filter out xbl:content. Consistency, please.

Comment 2

[Andrew McCreight [:mccr8]]

Note that I have a script, dom_grouper.py, that does this analysis, though the output isn't particularly great.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8398381 [details] [diff] [review]
Patch

r=me assuming the idea here is to make it easier to debug by pointing out DOM nodes being held by random script.  If that's the goal, it makes sense to filter out xbl:content, but then please document that's why it's being done.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

There can be also many other kinds of orphan nodes than those owned by JS.
event.target for example.

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Our experience is that nodes orphaned by C++ are much rarer than nodes orphaned directly by JS.

xbl:content nodes are never exposed to JS (afaict) so I think it's reasonable to ignore them, especially since they always seem to be "orphaned".

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/48c4861d8391

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/48c4861d8391