989249 - test_addon_reconciling.js broken due to missing sync

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Andrei Eftimie]

The summary is not very detailed as I'm still figuring out what happens.

The following tests are affected:
> test_addon_reconciling.js
> test_addon_wipe.js
Both pass with the old sync account.

At a first glance Addon state from the remote profile fails to sync to the local profile.

In the case of test_addon_wipe.js in phase02 we wipe local addons afterwards we sync. This should bring back the addons.

In the case of test_addon_reconciling.js we uninstall an addon on the remote profile. After a sync we expect the addon to not be installed in the local profile.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Andrei Eftimie from comment #0)
> In the case of test_addon_wipe.js in phase02 we wipe local addons afterwards
> we sync. This should bring back the addons.

What do you mean with 'should bring back the add-ons'? How do we wipe add-ons? If we uninstall them and do a sync afterward, shouldn't they get removed from the sync server? That's what I would expect.

> In the case of test_addon_reconciling.js we uninstall an addon on the remote
> profile. After a sync we expect the addon to not be installed in the local
> profile.

Same here. How do we uninstall? Does sync pick it up? It doesn't look like.

If you want to inspect what is existent on the sync server you should create a fresh profile and connect it to this sync account. After a manual sync, you will have the latest state available.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Also run those tests individually and attach the log output as attachment so we can see what happens.

Comment 3

[Andrei Eftimie]

Attachment: test_addon_reconciling_log.txt

Comment 4

[Andrei Eftimie]

Attachment: test_addon_wipe_log.txt

Here are logs for both of them.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Fix for test_addon_reconciling.js v1

test_addon_wipe.js seems to work with my patch from bug 989045 being applied. test_addon_reconciling.js will pass with the patch I'm putting up in a bit. Looks like it was missing the EnsureTracking and Sync tasks in step 4. I also added some more verifications for easier debugging.

Comment 6

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8399652 [details] [diff] [review]
Fix for test_addon_reconciling.js v1

Review of attachment 8399652 [details] [diff] [review]:
-----------------------------------------------------------------

These changes look good to me.

Comment 7

[Andrei Eftimie]

Comment on attachment 8399652 [details] [diff] [review]
Fix for test_addon_reconciling.js v1

Review of attachment 8399652 [details] [diff] [review]:
-----------------------------------------------------------------

test_addon_reconsiling.js still fails for me. I have both the patch from bug 989045 applied and this one.
> CROSSWEAVE INFO: Starting phase 2/6
> CROSSWEAVE INFO: setting client.name to profile2
> CROSSWEAVE INFO: ----------event observed: sessionstore-windows-restored
> CROSSWEAVE INFO: starting action: TPS__Sync
> CROSSWEAVE INFO: executing Sync
> CROSSWEAVE INFO: Setting client credentials and login.
> CROSSWEAVE INFO: Login user: [e-mail]
> CROSSWEAVE INFO: ----------event observed: fxaccounts:onlogin
> CROSSWEAVE INFO: Waiting for weave:service:setup-complete...
> CROSSWEAVE INFO: ----------event observed: weave:engine:start-tracking
> CROSSWEAVE INFO: ----------event observed: weave:service:setup-complete
> CROSSWEAVE INFO: weave:service:setup-complete observed!
> 1396337636113	addons.xpi	WARN	Error loading bootstrap.js for [e-mail]
> 1396337636113	addons.xpi	WARN	Add-on [e-mail] is missing bootstrap method install
> CROSSWEAVE INFO: ----------event observed: weave:service:sync:finish
> CROSSWEAVE INFO: ----------event observed: weave:service:sync:finish
> CROSSWEAVE INFO: starting action: Addons__verify
> CROSSWEAVE INFO: executing action VERIFY on addon "[e-mail]"
> CROSSWEAVE INFO: add-on found: [e-mail], enabled: false
> CROSSWEAVE ERROR: [phase02] Exception caught: ASSERTION FAILED! add-on is disabled: [e-mail] No traceback available
> 
> TEST-UNEXPECTED-FAIL | test_addon_reconciling.js | [phase02] Exception caught: ASSERTION FAILED! add-on is disabled: [e-mail] No traceback available

Also test_addon_wipe.js is still failing, with bug 989045 applied.

All this on OSX, latest Tinderbox Inbound build. I'll have a deeper look.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8399652 [details] [diff] [review]
Fix for test_addon_reconciling.js v1

Review of attachment 8399652 [details] [diff] [review]:
-----------------------------------------------------------------

Andrei, when you compare your initial comment and the latest failure you will see that it is different. This is maybe because the data on the server is busted. I had the same issue yesterday. I cleaned it up in another browser instance connected to this sync account, and it was working. So please check again and ensure that it is working for phase 4 and not phase 2. If phase 2 is always failing for you a new bug has to be raised.

Comment 9

[Andrei Eftimie]

With a fresh fx_account I don't have the failure in phase 2, but it still fails in phase 6:

> CROSSWEAVE INFO: test phase 05: PASS
> System JS : WARNING resource://tps/modules/bookmarks.jsm:39 - mutating the [[Prototype]] of an object will cause your code to run very slowly; instead create the object with the correct initial [[Prototype]] value using Object.create
> CROSSWEAVE INFO: Sync version: 1.33.0
> CROSSWEAVE INFO: Firefox buildid: 20140331232933
> CROSSWEAVE INFO: Firefox version: 31.0a1
> CROSSWEAVE INFO: Firefox Accounts enabled: true
> CROSSWEAVE INFO: ----------event observed: weave:engine:start-tracking
> CROSSWEAVE INFO: Waiting for weave:service:ready...
> CROSSWEAVE INFO: weave:service:ready observed!
> CROSSWEAVE INFO: Starting phase 6/6
> CROSSWEAVE INFO: setting client.name to profile2
> CROSSWEAVE INFO: ----------event observed: sessionstore-windows-restored
> CROSSWEAVE INFO: starting action: TPS__Sync
> CROSSWEAVE INFO: executing Sync
> 1396341082049	addons.xpi	WARN	Error loading bootstrap.js for [e-mail]
> 1396341082049	addons.xpi	WARN	Add-on [e-mail] is missing bootstrap method install
> CROSSWEAVE INFO: ----------event observed: weave:service:sync:finish
> CROSSWEAVE INFO: starting action: Addons__verifyNot
> CROSSWEAVE INFO: executing action VERIFY-NOT on addon "[e-mail]"
> CROSSWEAVE INFO: add-on found: [e-mail], enabled: false
> CROSSWEAVE ERROR: [phase06] Exception caught: ASSERTION FAILED! addon [e-mail] is present, but it shouldn't be No traceback available
> 
> TEST-UNEXPECTED-FAIL | test_addon_reconciling.js | [phase06] Exception caught: ASSERTION FAILED! addon [e-mail] is present, but it shouldn't be No traceback available
> 
> 	phase01: PASS
> 	phase02: PASS
> 	phase03: PASS
> 	phase04: PASS
> 	phase05: PASS
> 	phase06: FAIL
> Test Summary

Once I've run this test the first time, it will always fail in phase 2. I'll file another bug for this issue.

Comment 10

[Andrei Eftimie]

Interestingly this also fails with sync_account in the same place in phase 6:
> CROSSWEAVE ERROR: [phase06] Exception caught: ASSERTION FAILED! addon [e-mail] is present, but it shouldn't be No traceback available

Comment 11

[Andrei Eftimie]

Comment on attachment 8399652 [details] [diff] [review]
Fix for test_addon_reconciling.js v1

Review of attachment 8399652 [details] [diff] [review]:
-----------------------------------------------------------------

I was running this badly.
It work great!

> TEST-PASS | test_addon_reconciling.js
> 
> 	phase01: PASS
> 	phase02: PASS
> 	phase03: PASS
> 	phase04: PASS
> 	phase05: PASS
> 	phase06: PASS

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a3da1135317f

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a3da1135317f

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8399652 [details] [diff] [review]
Fix for test_addon_reconciling.js v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): None
User impact if declined: None, just testing code
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): None
String or IDL/UUID changes made by this patch: None

Comment 15

[Firefox Commit Bot]

The following changeset is now in Firefox Nightly:

> a3da1135317f Bug 989249 - test_addon_reconciling.js broken due to missing sync. r=jgriffin DONTBUILD

Nightly Build Information:

        ID: 20140402030201
 Changeset: 4941a2ac0786109b08856738019b016a6c5a66a6
   Version: 31.0a1
      TBPL: https://tbpl.mozilla.org/?rev=4941a2ac0786
       URL: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central

Download Links:

>         Linux x86: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-i686.tar.bz2
>      Linux x86_64: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-x86_64.tar.bz2
> Linux x86_64 ASAN: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-x86_64-asan.tar.bz2
>               Mac: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.mac.dmg
>             Win32: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.win32.installer.exe
>             Win64: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.win64-x86_64.installer.exe

Previous Nightly Build Information:

        ID: 20140401030203
 Changeset: 1417d180a1d8665b1a91b897d1cc4cc31e7980d4
   Version: 31.0a1
      TBPL: https://tbpl.mozilla.org/?rev=1417d180a1d8
       URL: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-01-03-02-03-mozilla-central

Comment 16

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 8399652 [details] [diff] [review]
Fix for test_addon_reconciling.js v1

[Triage Comment]
Given the low risk here and the affected on Beta, please also uplift there if it can land cleanly otherwise put up a new branch-specific patch for approval.

Comment 17

[Henrik Skupin [:whimboo][⌚️UTC+1]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/36985a1d7eae