989268 - [Tarako] Keyboard settings configuration

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Marvin Khoo [:Marvin_Khoo]]

Keyboard settings in 1.3T
1. Vibration, Default ON
2. Click sound, Default Off

Following item to disable in 1.3T
1. Auto correction - disable / hide
2. Word suggestion - disable / hide

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Should we just get rid of the dictionary/auto correction/word suggestion altogether?

Comment 2

[bhavana bajaj [:bajaj]]

Tim, can you please help find an owner here ?

Comment 3

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

I can handle this.

Comment 4

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Pull request 17789

This patch is to disable the following functions by default,
 1. Click sound
 2. Word suggestion
 3. Auto correction
While still keep "vibration" on.

The dictionaries would not be removed, so that the users still could enable the word suggestion manually.

Tim,

Could you help take a look?
Thanks.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #1)
> Should we just get rid of the dictionary/auto correction/word suggestion
> altogether?

We are disable the setting, not the feature.

ni? Marvin for sure.

Comment 6

[Marvin Khoo [:Marvin_Khoo]]

Hi Tim,
Sorry for misunderstanding, had discussed with Rudy and I played with build today, seems Rudy solution works fine for me.
so, correct the Description and 1.3T Keyboard Configuration here,

Keep "Vibration" Enable (On) and disable (Off) Click Sound, Word Suggestion and Auto Correction.

Thanks!

Hi Rudy, as discussed, the configure is good, let's move fwd the review process.

Comment 7

[bhavana bajaj [:bajaj]]

(In reply to Marvin Khoo [:Marvin_Khoo] from comment #6)
> Hi Tim,
> Sorry for misunderstanding, had discussed with Rudy and I played with build
> today, seems Rudy solution works fine for me.
> so, correct the Description and 1.3T Keyboard Configuration here,
> 
> Keep "Vibration" Enable (On) and disable (Off) Click Sound, Word Suggestion
> and Auto Correction.
> 
> Thanks!
> 
> Hi Rudy, as discussed, the configure is good, let's move fwd the review
> process.

:Marvin,

Can you explain the reasoning behind this decision a bit more ? You still want the feature enabled but just disabled by default ? What is the plan on blocking criteria for bugs around these features that may occur after the defaults are changed ?

Comment 8

[Marvin Khoo [:Marvin_Khoo]]

Sorry for late. original plan was to remove both Auto Correction and Word suggestion. After chat with Rudy, seems like there is no outstanding keyboard issue, (sounds to me this is green light) kindly share more inputs.

ofcos, once we have all keyboard features enabled, we must ensure all combination works well and QA don't have concern. As of default conf., i would say it gives the best perf & experiences.

As PM, Auto correct and Word suggest (prediction) is basic feature, if dev. drives has concerns, then bring it up and let's remove this asap.

thanks for raising this here.

Comment 9

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8399215 [details] [review]
Pull request 17789

Hi Dave,

This patch also modify the marionette python tests a little bit to enable the auto-correction/suggestion before the tests start.

Could you please review this?
Thank you.

Comment 10

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8399215 [details] [review]
Pull request 17789

Having autocorrect enabled for all tests was causing issues, so we switched to enabling it only for tests that require it. See https://github.com/mozilla-b2g/gaia/commit/4736ca3c3e38a5dfa4ad3aaaeac4f3154c0ef056

Comment 11

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8399215 [details] [review]
Pull request 17789

Hi Dave,

Thanks for the advice.
I just updated the patch. Could you please help take a look again?
Thanks.

Comment 12

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8399215 [details] [review]
Pull request 17789

Thanks. Do these changes need to be uplifted to master/v1.4 too?

Comment 13

[Marvin Khoo [:Marvin_Khoo]]

Hi Dave,this is keyboard configure is specifically for Tarako only.

Comment 14

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

v1.3t,
https://github.com/mozilla-b2g/gaia/commit/ffcec9ead0a3cc3064d8f3fd7c0070aa1f68ee78

Comment 15

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to Marvin Khoo [:Marvin_Khoo] from comment #13)
> Hi Dave,this is keyboard configure is specifically for Tarako only.

I understand that, but will tarako never be offered updates to later versions?

Comment 16

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Vibration is on by default and Click Sound, Word Suggestion, and Auto Correction have been cut. Verified Fixed


1.3t Environmental Variables:
Device: Tarako 1.3t
BuildID: 20140501014002
Gaia: d26a776beae0070b0032248a2ce482bbe6321a6d
Gecko: e90f4b655511
Version: 28.1
Firmware Version: sp6821