Closed Bug 989268 Opened 6 years ago Closed 6 years ago

[Tarako] Keyboard settings configuration

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(blocking-b2g:1.3T+, b2g-v1.3T verified)

VERIFIED FIXED
blocking-b2g 1.3T+
Tracking Status
b2g-v1.3T --- verified

People

(Reporter: mkhoo, Assigned: rudyl)

Details

(Whiteboard: 1.3tarakorun1,[FT:System-Platform][tarako_only])

Attachments

(1 file)

Keyboard settings in 1.3T
1. Vibration, Default ON
2. Click sound, Default Off

Following item to disable in 1.3T
1. Auto correction - disable / hide
2. Word suggestion - disable / hide
blocking-b2g: --- → 1.3T?
Whiteboard: 1.3tarakorun1
Hardware: x86 → ARM
Whiteboard: 1.3tarakorun1 → 1.3tarakorun1,[FT:System-Platform]
Should we just get rid of the dictionary/auto correction/word suggestion altogether?
blocking-b2g: 1.3T? → 1.3T+
Tim, can you please help find an owner here ?
Flags: needinfo?(timdream)
I can handle this.
Assignee: nobody → rlu
Flags: needinfo?(timdream)
Attached file Pull request 17789
This patch is to disable the following functions by default,
 1. Click sound
 2. Word suggestion
 3. Auto correction
While still keep "vibration" on.

The dictionaries would not be removed, so that the users still could enable the word suggestion manually.

Tim,

Could you help take a look?
Thanks.
Attachment #8399215 - Flags: review?(timdream)
Attachment #8399215 - Flags: review?(timdream) → review+
(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #1)
> Should we just get rid of the dictionary/auto correction/word suggestion
> altogether?

We are disable the setting, not the feature.

ni? Marvin for sure.
Flags: needinfo?(mkhoo)
Hi Tim,
Sorry for misunderstanding, had discussed with Rudy and I played with build today, seems Rudy solution works fine for me.
so, correct the Description and 1.3T Keyboard Configuration here,

Keep "Vibration" Enable (On) and disable (Off) Click Sound, Word Suggestion and Auto Correction.

Thanks!

Hi Rudy, as discussed, the configure is good, let's move fwd the review process.
Flags: needinfo?(mkhoo)
(In reply to Marvin Khoo [:Marvin_Khoo] from comment #6)
> Hi Tim,
> Sorry for misunderstanding, had discussed with Rudy and I played with build
> today, seems Rudy solution works fine for me.
> so, correct the Description and 1.3T Keyboard Configuration here,
> 
> Keep "Vibration" Enable (On) and disable (Off) Click Sound, Word Suggestion
> and Auto Correction.
> 
> Thanks!
> 
> Hi Rudy, as discussed, the configure is good, let's move fwd the review
> process.

:Marvin,

Can you explain the reasoning behind this decision a bit more ? You still want the feature enabled but just disabled by default ? What is the plan on blocking criteria for bugs around these features that may occur after the defaults are changed ?
Flags: needinfo?(mkhoo)
Sorry for late. original plan was to remove both Auto Correction and Word suggestion. After chat with Rudy, seems like there is no outstanding keyboard issue, (sounds to me this is green light) kindly share more inputs.

ofcos, once we have all keyboard features enabled, we must ensure all combination works well and QA don't have concern. As of default conf., i would say it gives the best perf & experiences.

As PM, Auto correct and Word suggest (prediction) is basic feature, if dev. drives has concerns, then bring it up and let's remove this asap.

thanks for raising this here.
Flags: needinfo?(mkhoo)
Comment on attachment 8399215 [details] [review]
Pull request 17789

Hi Dave,

This patch also modify the marionette python tests a little bit to enable the auto-correction/suggestion before the tests start.

Could you please review this?
Thank you.
Attachment #8399215 - Flags: review?(dave.hunt)
Comment on attachment 8399215 [details] [review]
Pull request 17789

Having autocorrect enabled for all tests was causing issues, so we switched to enabling it only for tests that require it. See https://github.com/mozilla-b2g/gaia/commit/4736ca3c3e38a5dfa4ad3aaaeac4f3154c0ef056
Attachment #8399215 - Flags: review?(dave.hunt) → review-
Comment on attachment 8399215 [details] [review]
Pull request 17789

Hi Dave,

Thanks for the advice.
I just updated the patch. Could you please help take a look again?
Thanks.
Attachment #8399215 - Flags: review- → review?(dave.hunt)
Whiteboard: 1.3tarakorun1,[FT:System-Platform] → 1.3tarakorun1,[FT:System-Platform][tarako_only]
Comment on attachment 8399215 [details] [review]
Pull request 17789

Thanks. Do these changes need to be uplifted to master/v1.4 too?
Attachment #8399215 - Flags: review?(dave.hunt) → review+
Hi Dave,this is keyboard configure is specifically for Tarako only.
v1.3t,
https://github.com/mozilla-b2g/gaia/commit/ffcec9ead0a3cc3064d8f3fd7c0070aa1f68ee78
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
(In reply to Marvin Khoo [:Marvin_Khoo] from comment #13)
> Hi Dave,this is keyboard configure is specifically for Tarako only.

I understand that, but will tarako never be offered updates to later versions?
Vibration is on by default and Click Sound, Word Suggestion, and Auto Correction have been cut. Verified Fixed


1.3t Environmental Variables:
Device: Tarako 1.3t
BuildID: 20140501014002
Gaia: d26a776beae0070b0032248a2ce482bbe6321a6d
Gecko: e90f4b655511
Version: 28.1
Firmware Version: sp6821
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.