If the serial number needs to be truncated, the left side should be truncated

RESOLVED WONTFIX

Status

Core Graveyard
Security: UI
P2
enhancement
RESOLVED WONTFIX
16 years ago
a year ago

People

(Reporter: Bob Lord, Unassigned)

Tracking

1.0 Branch
x86
Windows 2000

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

1.73 KB, patch
Javier Delgadillo
: review+
Details | Diff | Splinter Review
1.71 KB, patch
Joe Hewitt (gone)
: superreview+
Details | Diff | Splinter Review
(Reporter)

Description

16 years ago
I find myself wanting to know the serial number of my certs much more often than
the issuance date.  We should still allow the user to see the Issued On column,
but it should be off by default.  The Serial Number column should be on by default.
(Reporter)

Comment 1

16 years ago
If the serial number needs to be truncated, the left side should be truncated. 
For example:

...41:74:AA:21

Comment 2

16 years ago
->rangansen
Assignee: ssaux → rangansen
Priority: -- → P2
Target Milestone: --- → Future

Updated

16 years ago
QA Contact: bsharma → junruh

Comment 3

16 years ago
Created attachment 51300 [details] [diff] [review]
patch

Comment 4

16 years ago
This patch provides a partial fix to the issue. 
This is what it does :
puts the serial number as a new col. Issue Date column still exists ... but
hidden by default. Note: 'hidden' property of columns being persistent, 'issue
date' would be hidden only on new profiles. On old profiles both 'serial number'
and 'issue date' would show up.

What it does not : The serial number col is aligned to the left - which means it
get truncated as  41:74:AA:21.... rather than ....41:74:AA:21. Shall try to
resolve this - at present it looks like align does not work ok with Outliners
and  enforces all columns to get left aligned.

Updated

16 years ago
Status: NEW → ASSIGNED

Updated

16 years ago
Keywords: patch

Updated

16 years ago
Attachment #51300 - Flags: needs-work+

Comment 5

16 years ago
Comment on attachment 51300 [details] [diff] [review]
patch

why are we actually keeping the issued on column?  Do we actually want to remove it?  If so, then we should actually remove it and remove the associated code.

Comment 6

16 years ago
As I understand, we still want to have the 'issued on' column - but turned off
by default, unless the user explicitly turns it on  ... the serial number column
would be turned on by default... 

Comment 7

16 years ago
Comment on attachment 51300 [details] [diff] [review]
patch

in that case, r=javi
Attachment #51300 - Flags: review+

Comment 8

16 years ago
Comment on attachment 51300 [details] [diff] [review]
patch

do you really need the align="end" on the outlinercol?

Comment 9

16 years ago
Not really - I was trying to get the outliner col left aligned, but doesn't seem
to work, even with align=left - any suggestions on that ..? 
Here's the new patch anyway .. removed the align property.

Comment 10

16 years ago
Created attachment 56190 [details] [diff] [review]
new patch

Comment 11

16 years ago
Comment on attachment 56190 [details] [diff] [review]
new patch

sr=hewitt
Attachment #56190 - Flags: superreview+

Comment 12

16 years ago
Patch checked in... But the fix is partial, in the sense that the serial number
are still left aligned that is, tunncated as 41:74....
clearing patch keyword since patch is in
Keywords: patch

Comment 14

15 years ago
Changing summary, since one of the bugs is fixed.
Severity: normal → enhancement
Summary: CertManager: replace "Issued On" column with "Serial Number" → If the serial number needs to be truncated, the left side should be truncated
Version: 2.0 → 2.4
reassign former PSM engineers' bugs to nobody
Assignee: rangansen → nobody
Status: ASSIGNED → NEW
QA Contact: junruh → nobody
Target Milestone: Future → ---

Updated

13 years ago
Component: Security: UI → Security: UI
Product: PSM → Core
QA Contact: nobody → ui

Updated

10 years ago
Version: psm2.4 → 1.0 Branch
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → WONTFIX
(Assignee)

Updated

a year ago
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.