989275 - Site tries to decodeURIComponent(unescape(uri)), which throws if the URI contained an escaped '%'

Status: RESOLVED INVALID

(Tech Evangelism Graveyard :: English US, defect)

Description

[Jim Michaels]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 (Beta/Release)
Build ID: 20140314220517

Steps to reproduce:

http://jesusnjim.com/pc-repair/speed-up/maximize-cpu-performance-disable-core-parking.html
used method="get" in form and did submit. click "create bookmarkable URL" to do the submit.
do ctrl-shift-i
click console. refresh/F5 if you have to.



Actual results:

debugger gives error message "URIError: malformed URI sequence geturlargs.js:104"
ff throws an error at its own generated URL.



Expected results:

no error.

Comment 1

[[:Aleksej]]

Reproduced with 2014-04-02-03-02-01-mozilla-central-firefox-31.0a1.en-US.linux-x86_64.  Core::General, because the report is about the submission disagreeing with the function, although I suspect the function is right.

Comment 2

[Boris Zbarsky [:bzbarsky]]

The relevant URI is http://jesusnjim.com/pc-repair/speed-up/maximize-cpu-performance-disable-core-parking.html?imaxtemp=66.8&temptype=C&imarginpct=85%25

The page then calls getURLargs(), which takes document.location.toString(), looks at the part after '?', splits it on '&', splits each element of the resulting array on '=', and then passes the RHS one at a time to URIToString().  So in this case it's passing "85%25".

Here's what URIToString does:

  s=decodeURIComponent(unescape(s))

which is, of course buggy.  A simple console session:

  decodeURIComponent("85%25")
    "85%"
  unescape("85%25")
    "85%"
  decodeURIComponent(unescape("85%25"))
    URIError: malformed URI sequence

So this is just a site bug with trying to unescape twice instead of once, not a problem with either form submission or decodeURIComponent...

Note that other browsers throw the same exception, for the same reason.

Over to evangelism, but since it's broken in all browsers maybe just marking invalid is better....